Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow customizing quoting behavior of emit (#34) #35

Merged
merged 4 commits into from
Jul 8, 2022
Merged

feat: allow customizing quoting behavior of emit (#34) #35

merged 4 commits into from
Jul 8, 2022

Conversation

TimHambourger
Copy link
Contributor

Implements #34.

piotr-oles
piotr-oles reviewed Jul 7, 2022
View reviewed changes
Copy link
Owner

@piotr-oles piotr-oles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, looks great! I left a few small comments, we're good to go after addressing them :)

packages/emitter/src/index.ts Show resolved Hide resolved
packages/emitter/src/index.ts Outdated Show resolved Hide resolved
packages/emitter/src/index.ts Outdated Show resolved Hide resolved
@TimHambourger
Copy link
Contributor Author

@piotr-oles Thanks! Made those updates. I also forgot that I'd meant to update the emitter readme to mention the new options, so I did that as well.

@piotr-oles piotr-oles added the minor Increment the minor version when merged label Jul 8, 2022
@piotr-oles piotr-oles merged commit 9e613d9 into piotr-oles:master Jul 8, 2022
@piotr-oles piotr-oles mentioned this pull request Jul 8, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🚀 PR was released in v1.4.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Jul 8, 2022
@TimHambourger TimHambourger deleted the feature/34-customize-quoting branch July 9, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-oles piotr-oles piotr-oles left review comments

Assignees
No one assigned
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimHambourger @piotr-oles