-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paint Shop - Randomize colors #6069
Conversation
Nice idea! |
00fb8fa
to
7f11bad
Compare
Squashed and done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👍
Found an issue. The Buttons don't scale well on lower resolution. Looking into. |
I think that's a known issue with the UI. How low a resolution are you looking at because I think it was discussed that anything below 800x600 there are scaling issues throughout the UI |
OK. I fixed the width on the buttons I worked with here. I haven't looked at the rest of Pioneer though. On screen sizes below 800x600 you see the right side, color selection, being pushed down a bit and given a scroll bar as the top left button, Visit Repair Services, reserves space along the whole top of the screen. That could be fixed to make it reserve space just above the model spinner. I failed to find a quick solution for it here though. |
Our "soft" minimum size for the UI is 1280x720 and we do not target screen sizes smaller than 800x600 at all. I wouldn't worry about the behavior of the paint shop as long as it looks good at 800x600 and larger. |
I'll merge this for the upcoming hotfix if you squash the branch. Thanks for the contribution! |
b95afe9
to
9470aeb
Compare
OK. Squashed!
Reasonable. However, I tested (taking from memory now) the menus at 800x600 and the paintshop was the only one that looked a bit off. If it's an easy fix I think it could be worth the effort. |
Add a button to randomize the colors in the Paint Shop
It randomizes: