Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint Shop - Randomize colors #6069

Merged
merged 1 commit into from
Mar 22, 2025

Conversation

zonkmachine
Copy link
Member

paintshoprandom1
paintshoprandom2

Add a button to randomize the colors in the Paint Shop
It randomizes:

  • All colors to different values (top image)
  • Two colors the same value
  • All colors the same value (bottom image)

@bszlrd
Copy link
Contributor

bszlrd commented Feb 12, 2025

Nice idea!

@zonkmachine zonkmachine force-pushed the paintshoprandom branch 2 times, most recently from 00fb8fa to 7f11bad Compare February 13, 2025 00:36
@zonkmachine
Copy link
Member Author

Squashed and done.

Copy link
Contributor

@fluffyfreak fluffyfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea 👍

@zonkmachine
Copy link
Member Author

Found an issue. The Buttons don't scale well on lower resolution. Looking into.

@fluffyfreak
Copy link
Contributor

I think that's a known issue with the UI. How low a resolution are you looking at because I think it was discussed that anything below 800x600 there are scaling issues throughout the UI

@zonkmachine
Copy link
Member Author

I think it was discussed that anything below 800x600 there are scaling issues throughout the UI

OK. I fixed the width on the buttons I worked with here. I haven't looked at the rest of Pioneer though. On screen sizes below 800x600 you see the right side, color selection, being pushed down a bit and given a scroll bar as the top left button, Visit Repair Services, reserves space along the whole top of the screen. That could be fixed to make it reserve space just above the model spinner. I failed to find a quick solution for it here though.

@sturnclaw
Copy link
Member

Our "soft" minimum size for the UI is 1280x720 and we do not target screen sizes smaller than 800x600 at all. I wouldn't worry about the behavior of the paint shop as long as it looks good at 800x600 and larger.

@sturnclaw
Copy link
Member

I'll merge this for the upcoming hotfix if you squash the branch. Thanks for the contribution!

@zonkmachine
Copy link
Member Author

I'll merge this for the upcoming hotfix if you squash the branch. Thanks for the contribution!

OK. Squashed!

Our "soft" minimum size for the UI is 1280x720 and we do not target screen sizes smaller than 800x600 at all.

Reasonable. However, I tested (taking from memory now) the menus at 800x600 and the paintshop was the only one that looked a bit off. If it's an easy fix I think it could be worth the effort.

@sturnclaw sturnclaw merged commit f4c096f into pioneerspacesim:master Mar 22, 2025
@zonkmachine zonkmachine deleted the paintshoprandom branch March 22, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants