-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipjack Courier from OKB Kaluri (by BobThreTerrible) #4871
Conversation
Since we seem to be leaning to adding git-lfs with #4554, we might as well make the switch now, and move models and music into it now, and make proper adjustments for this PR to put it in LFS. Thus, I'd like to probe what others think of making this move now, with this ship/PR? It is a bit of work (I'm reading up on it now), I assume various packages would need upgrading (flatpack, arch/aur, debian, fedora) and travis/appveyor, and COMPILING.txt. |
The downside to Git LFS is that we either need to host it ourselves somewhere or pay Github for it - Github provides 1GB of free storage (and 1GB of bandwidth per month) while we have almost 900MB of file history in the repo:
Added to that, each version of a file in Git LFS history counts for storage size - so if we make changes to a DDS file and re-push, we're now using twice as much storage for that file. |
https://pioneerspacesim.net/forum/viewtopic.php?p=6383#p6383 |
Wait with merging this please, @BobTheTerrible and @keeper were doing some texture work. |
Adding two patterns, made by @keeper and @BobTheTerrible. Uncommenting the use_patterns line in skipjack.model
@BobTheTerrible, @keeper I've added your patterns. |
Cool! Then I suggest some grace period where I explore LFS, and if that works out, this will be moved into LFS instead into this git repo, so I suggest to hold on merging this a while, while I investigate our options. |
Woo! Great news, many thanks!! :-D
…On Wed, 19 Aug 2020, 19:27 Szlrd, ***@***.***> wrote:
@BobTheTerrible <https://github.com/BobTheTerrible>, @keeper
<https://github.com/keeper> I've added your patterns.
@impaktor <https://github.com/impaktor> This should be good to merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4871 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2WY4UIHGPKFED3T3LVHSTSBQKQ7ANCNFSM4MXZQ5SQ>
.
|
Built fuel tanks and cargo capacity according to physical dimensions Assumes ~40m3 for hyperdrive space Adjust price semi-randomly based on Nozmajner's rebalance spreadsheet
Slightly tweaked stats to reduce that new ship feel, slightly improved it's handling overall and improved in-atmosphere performance a bit as well. It's roughly stable at mach 2 (definitely have problems with our atmospheric flight model but that's for another day...) and I didn't touch the drag coefficients, so it still flies like a sphere. In sum, I'm good to merge this in. We're not going to go the LFS route unless we're totally migrating to Gitlab or a Gitea instance, so there's no need to delay further. |
A new ship coming up, courtesy of @BobTheTerrible.
A Medium Courier named Skipjack from OKB Kaluri.
Has an ample capacity and a rather nice deltaV, but not as nimble as the Light Couriers. It can still sit on the small pads though!
But I let the man do the describing: