Skip to content

Conversation

@philipch07
Copy link
Contributor

Description

Improves the data-channels example so hopefully it's clear for newcomers (such as myself) to pick up on what's going on!

Reference issue

I was using it to test my SCTP RACK impl, but had some issues figuring out what exactly was going on. Fortunately it seems to work fine.

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.80%. Comparing base (7d8a700) to head (1d1fbc0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3251      +/-   ##
==========================================
- Coverage   82.87%   82.80%   -0.08%     
==========================================
  Files          80       80              
  Lines       11196    11196              
==========================================
- Hits         9279     9271       -8     
- Misses       1498     1504       +6     
- Partials      419      421       +2     
Flag Coverage Δ
go 82.80% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@JoeTurki JoeTurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@JoeTurki JoeTurki merged commit 8f7e057 into master Oct 21, 2025
20 checks passed
@JoeTurki JoeTurki deleted the pch07/update-data-channels-example branch October 21, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants