Export ClientWithOptionsContext#473
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
==========================================
- Coverage 84.54% 84.46% -0.08%
==========================================
Files 56 56
Lines 5267 5267
==========================================
- Hits 4453 4449 -4
- Misses 579 581 +2
- Partials 235 237 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you, I'll try to review it in the morning, one thing tho, we shouldn't add withOptions to the name as this is a temporary name until we release the next major version and move to functional option only. |
|
Got it, thanks, and the reason is what I explained in the PR description, a follow-up PR will need this to add SCTPTransport.StartContext which is for the same reason of pion/webrtc#3371 |
The WithOptions suffix is transitional naming that will be dropped in the next major version when the functional-options constructor becomes Client. Name the exported context variant ClientContext so it stays stable across that change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
@JoTurk let me know if anything else is needed, thanks! |
|
Sounds good, I'll try to check this tonight |
2 participants
This PR exports
ClientWithOptionsContextso that a follow-up pion/webrtc PR can implementSCTPTransport.StartContext.