Update packet to RFC 9260 #407
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipch07
force-pushed
the
pch07/update-packet-to-rfc-9260
branch
from
2fd889e to
46720cf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 81.77% 82.10% +0.32%
==========================================
Files 51 51
Lines 4522 4520 -2
==========================================
+ Hits 3698 3711 +13
+ Misses 680 666 -14
+ Partials 144 143 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philipch07
force-pushed
the
pch07/update-packet-to-rfc-9260
branch
2 times, most recently
from
2ea6476 to
121a82f
Compare
JoeTurki
reviewed
Oct 19, 2025
packet.go
Outdated
| for _, c := range p.chunks { | ||
| switch c.(type) { | ||
| case *chunkInit, *chunkCookieEcho: | ||
| doChecksum = false |
There was a problem hiding this comment.
not sure about having state / side effect in marshal is this necessary to do here?
There was a problem hiding this comment.
Thanks for catching this, I was messing with some variable names and accidentally left this in. I changed it to use a helper so it's a little more straightforward (and it avoids manipulating the input).
philipch07
force-pushed
the
pch07/update-packet-to-rfc-9260
branch
from
121a82f to
91865dc
Compare
philipch07
force-pushed
the
pch07/update-packet-to-rfc-9260
branch
from
91865dc to
561cd4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: The chunk test is modified since it uses packets, which has changed.
Reference issue
A part of #402. Split from #406.