Skip to content

Conversation

@philipch07
Copy link
Contributor

@philipch07 philipch07 commented Oct 17, 2025

Description

A leak was found in pop where pendingBaseQueue.pop() would have the slice keep a reference to the popped element.

I also added a regression test to prevent us from having this issue again.

I am unsure if we still want to turn this into a list to allow for gc as referenced in here: #264 considering that we still want the v2 rewrite. I don't mind looking into rebasing that PR if there's any demand for it.

Reference issue

The issue was reported here: #264 (comment)

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.12%. Comparing base (c875185) to head (cf65cf5).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   81.77%   82.12%   +0.34%     
==========================================
  Files          51       51              
  Lines        4522     4525       +3     
==========================================
+ Hits         3698     3716      +18     
+ Misses        680      670      -10     
+ Partials      144      139       -5     
Flag Coverage Δ
go 82.12% <100.00%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@philipch07 philipch07 force-pushed the pch07/fix-pending-queue-pop-leak branch 5 times, most recently from b7b570a to 7890e21 Compare October 17, 2025 20:30
@philipch07 philipch07 force-pushed the pch07/fix-pending-queue-pop-leak branch from 7890e21 to cf65cf5 Compare October 18, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant