Fix a leak with pop in pending_queue #401
Open
+160
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A leak was found in pop where
pendingBaseQueue.pop()would have the slice keep a reference to the popped element.I also added a regression test to prevent us from having this issue again.
I am unsure if we still want to turn this into a list to allow for gc as referenced in here: #264 considering that we still want the v2 rewrite. I don't mind looking into rebasing that PR if there's any demand for it.
Reference issue
The issue was reported here: #264 (comment)