-
Notifications
You must be signed in to change notification settings - Fork 87
Added DialAssociation and ListenAssociation #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
- Coverage 78.62% 76.22% -2.40%
==========================================
Files 43 45 +2
Lines 2779 2869 +90
==========================================
+ Hits 2185 2187 +2
- Misses 459 548 +89
+ Partials 135 134 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
These are helpers to easily run SCTP over UDP. Example adapted. I added the Association postfix to keep space for a potential Dial/Listen implementation that directly gives you a Stream. Relates to #74
This comment has been minimized.
This comment has been minimized.
Dial & Listen with sane but over-writable defaults. Relates to #74
hey @backkem we're starting to work on a v2, that could include SCTP support over not just DTLS. Is this something you'd like to work on getting in still? |
I would be interested in SCTP over IP as well. @edaniels How do plan to start the work on v2? Is there a separate branch? |
@edaniels my original goal for pushing this was to make each protocol in the stack usable in their own right, not just for WebRTC. I don't have a use-case for this myself at the moment. Feel free to take this over. |
@stv0g i think we can just cut to v2 whenever on master and if we need back ports make a v1 branch? What do you think? |
Regarding an overall plan, don't quite have one yet but as long as we don't tag a release for it, we can be in flux API wise |
@stv0g is making this work over IP something you'd want to take on? |
These are helpers to easily run SCTP over UDP. Example adapted.
I added the Association postfix to keep space for a potential
Dial/Listen implementation that directly gives you a Stream.
Relates to #74
TODO: