Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in nack responder #311

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

aalekseevx
Copy link
Member

Description

Fixes the following panic:

fatal error: concurrent map read and map write 
github.com/pion/interceptor/pkg/nack.(*ResponderInterceptor).BindLocalStream.func1(0xc0b16fae10, {0xc03af93210, 0x467, 0x467}, 0xc0a8afe9c0)
github.com/pion/interceptor/pkg/nack/responder_interceptor.go:126 +0x145 github.com/pion/interceptor.RTPWriterFunc.Write

Looks like race was introduced in d34a3c5

@aalekseevx aalekseevx requested a review from Sean-Der February 6, 2025 14:21
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.41%. Comparing base (60fb984) to head (3755e63).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   71.41%   71.41%           
=======================================
  Files          79       79           
  Lines        4530     4531    +1     
=======================================
+ Hits         3235     3236    +1     
  Misses       1158     1158           
  Partials      137      137           
Flag Coverage Δ
go 71.41% <100.00%> (+0.13%) ⬆️
wasm 69.38% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aalekseevx aalekseevx force-pushed the fix-nack-responder-race branch from 03ab82f to 3755e63 Compare February 6, 2025 14:24
@aalekseevx
Copy link
Member Author

Thanks, @nils-ohlmeier

@aalekseevx aalekseevx merged commit 289432d into pion:master Feb 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants