Allow intercepting and injecting DTLS packets #766
Conversation
which allows embedding them into STUN.
fippo
force-pushed
the
dtls-intercept
branch
from
d60f060 to
a743812
Compare
conn.go
Outdated
|
|
||
| var rawPackets [][]byte | ||
|
|
||
| // TODO: this is not quite correct. |
There was a problem hiding this comment.
"writePackets" is an odd name, this writes a series of records? Intercepting here is wrong since the goal is to intercept the handshake packets, not the individual records.
Theoretically handshake and non-handshake records could be mixed but I think that isn't allowed (at least in DTLS 1.2)
There was a problem hiding this comment.
Best way I came up with so far is to split the handling of handshake packets into a writeHandshakePackets (which seems like a general improvement) and call that from handshaker.go -- done in f501150
conn.go
Outdated
| // We need the full packets for SPED so we can crc32 them (at least the ones | ||
| // received in plain!) | ||
| } | ||
| */ |
There was a problem hiding this comment.
same problem as above, this is about records, not packets.
There was a problem hiding this comment.
likewise, readAndBuffer already has a hasHandshake which could be used for an inbound interceptor (which should only be used to to let the piggybacking controller calculate and store the crc32).
There was a problem hiding this comment.
787aa43 adds an inbound notifier (which can not intercept packets)
fippo
force-pushed
the
dtls-intercept
branch
from
f501150 to
009f89e
Compare
fippo
force-pushed
the
dtls-intercept
branch
from
16f2df2 to
787aa43
Compare
1 participant
which allows embedding them into STUN.