Skip to content

Conversation

@hanguyen-nuro
Copy link
Contributor

@hanguyen-nuro hanguyen-nuro commented Oct 28, 2025

Fix no rear / topdown camera.
Fix flickering due to fps.
Tested with playback on Nuro branch.

  • Allow tracks with zero bitrate allocation to be created
  • Keep zero-bitrate tracks active during runtime updates
  • Use minimum 1000 bps for zero-bitrate track encoders
  • Prevents connection loss for cameras with zero allocation
  • Makes RTCSender behavior match NuroSender exactly

Fixes issues where cameras with 0 bitrate allocation would:

  1. Fail to be created during initialization
  2. Lose connection during runtime bitrate updates

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.39%. Comparing base (96e4855) to head (d02034c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
sender/rtc_sender.go 30.76% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (30.76%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   33.33%   33.39%   +0.06%     
==========================================
  Files          18       18              
  Lines        1542     1542              
==========================================
+ Hits          514      515       +1     
  Misses        981      981              
+ Partials       47       46       -1     
Flag Coverage Δ
go 33.39% <30.76%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hanguyen-nuro hanguyen-nuro changed the title Fix/rtcsender nuro compatibility fix(rtc-sender): Allow RTCSender to create tracks with zero InitialBitrate Oct 28, 2025
@hanguyen-nuro hanguyen-nuro force-pushed the fix/rtcsender-nuro-compatibility branch from 879f88c to 524a757 Compare October 28, 2025 23:46
- Allow tracks with zero bitrate allocation to be created
- Keep zero-bitrate tracks active during runtime updates
- Use minimum 1000 bps for zero-bitrate track encoders
- Prevents connection loss for cameras with zero allocation
- Makes RTCSender behavior match NuroSender exactly

Fixes issues where cameras with 0 bitrate allocation would:
1. Fail to be created during initialization
2. Lose connection during runtime bitrate updates
@hanguyen-nuro hanguyen-nuro force-pushed the fix/rtcsender-nuro-compatibility branch from 524a757 to fb2578f Compare October 28, 2025 23:48
@hanguyen-nuro hanguyen-nuro merged commit bc7f332 into master Oct 30, 2025
18 of 19 checks passed
@hanguyen-nuro hanguyen-nuro deleted the fix/rtcsender-nuro-compatibility branch October 30, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants