-
Notifications
You must be signed in to change notification settings - Fork 51
speed up FS upload targets #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
by disabling the not needed LDF in this targets
WalkthroughThe update modifies the Python path setup logic by removing fallback handling for site-packages discovery, relying solely on subprocess output. Additionally, a new function is introduced to disable the Library Dependency Finder (LDF) in the project configuration when certain filesystem-related build targets are detected. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
builder/main.py
(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: build (macos-15, examples/espidf-peripherals-uart)
- GitHub Check: build (macos-15, examples/espidf-arduino-matter-light)
- GitHub Check: build (macos-15, examples/espidf-arduino-littlefs)
- GitHub Check: build (macos-15, examples/espidf-arduino-blink)
- GitHub Check: build (windows-latest, examples/espidf-blink)
- GitHub Check: build (windows-latest, examples/arduino-wifiscan)
- GitHub Check: build (windows-latest, examples/arduino-blink)
🔇 Additional comments (2)
builder/main.py (2)
648-662
: LGTM! Well-implemented optimization for filesystem targets.The function correctly identifies filesystem-related targets and disables LDF to improve build performance. The implementation properly handles project configuration sections and aligns perfectly with the PR objective of speeding up FS upload targets.
807-809
: Appropriate placement for LDF optimization.The function call is correctly positioned after framework-specific configuration loading, ensuring that LDF is disabled unconditionally for the identified targets.
by disabling the not needed LDF in this targets
Checklist:
Summary by CodeRabbit
New Features
Refactor