Fix autocorrect for single line if/else expressions #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
reviewed
Apr 26, 2020
...xperimental/src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/MultiLineIfElseRule.kt
Show resolved
Hide resolved
romtsn
reviewed
Apr 26, 2020
...xperimental/src/main/kotlin/com/pinterest/ktlint/ruleset/experimental/MultiLineIfElseRule.kt
Show resolved
Hide resolved
|
@csgulley could you rebase so the checks can pass again? |
csgulley
force-pushed
the
multi_line_if_else_autocorrect
branch
from
bf311f0
to
d42fa29
Compare
|
Sorry for coming up with edge-cases again, but could you also add a test with |
|
@csgulley I've updated the handling myself in case if |
romtsn
force-pushed
the
multi_line_if_else_autocorrect
branch
from
cfe12a1
to
a0512cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the autocorrect functionality in MultiLineIfElseRule that was partially implemented but commented out. It should resolve #174.