Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't remove arrow from lambdas that are when/if leaf nodes #2758

Merged

Conversation

tKe
Copy link
Contributor

@tKe tKe commented Aug 1, 2024

Description

this fixes a problem with the function-literal rule removing non-redundant arrows from lambdas that are direct leafs of a when-entry or then/else. Without the arrow, the expression is left as a block instead.

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@tKe tKe changed the title 4fix: don't remove arrow from lamdas thare are when/if leaf nodes fix: don't remove arrow from lamdas thare are when/if leaf nodes Aug 1, 2024
@tKe tKe changed the title fix: don't remove arrow from lamdas thare are when/if leaf nodes fix: don't remove arrow from lamdas that are when/if leaf nodes Aug 2, 2024
@tKe tKe changed the title fix: don't remove arrow from lamdas that are when/if leaf nodes fix: don't remove arrow from lambdas that are when/if leaf nodes Aug 2, 2024
@paul-dingemans
Copy link
Collaborator

Tnx for your contribution. I refactored the code a bit, so that it complies more with current coding styles.

@paul-dingemans paul-dingemans merged commit 1845934 into pinterest:master Aug 6, 2024
11 checks passed
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants