Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent line separators to be changed from CRLF to LF #2752

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

When running on Windows, and end_of_line property not set in .editorconfig the line separators should not be changed from CRLF to LF whenever the file does not contain any lint violation that can be autocorrected.

Closes #2747

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

When running on Windows, and `end_of_line` property not set in `.editorconfig` the line separators should not be changed from CRLF to LF whenever the file does not contain any lint violation that can be autocorrected.

Closes #2747
@paul-dingemans paul-dingemans added this to the 1.4.0 milestone Jul 23, 2024
@paul-dingemans paul-dingemans merged commit 0b575a0 into master Jul 23, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2747-crlf-line-separator branch July 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ktlint 1.3.* converts crlf to lf on Windows
1 participant