Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set and reset Locale to pass test for non-english contributor. #2622

Merged
merged 7 commits into from
Apr 6, 2024
Merged

Set and reset Locale to pass test for non-english contributor. #2622

merged 7 commits into from
Apr 6, 2024

Commits on Apr 1, 2024

  1. Set and reset Locale to pass test for non-english contributor.

    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    75c89a3 View commit details
    Browse the repository at this point in the history

  2. Set and reset Locale to pass test for non-english contributor. 

    Fixes pinterest#2621
    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a7f0f05 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/fix-locale' into fix-locale

    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    1b212ee View commit details
    Browse the repository at this point in the history

  4. Apply ktlint.

    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    2a25575 View commit details
    Browse the repository at this point in the history

  5. Remove variable currentLocale and Locale Helper function.

    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    c38d2f4 View commit details
    Browse the repository at this point in the history

  6. Create BeforeEach and AfterEach to set locale and reset.

    @Jaehwa-Noh
    Jaehwa-Noh committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    3c6498f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Add clarifying comment

    @paul-dingemans
    paul-dingemans authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    491b315 View commit details
    Browse the repository at this point in the history