Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore modifier of backing property in android_studio code style #2552

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Ignore modifier of backing property in android_studio code style

Extract backing-property-name from property-naming rule. This allows users to disable this rule, but keep the property-naming rule in place.

For android_studio code style the restrictions regarding the modifier of the correlated property or function is ignored entirely as the Android Kotlin Styleguide does not require it to be public.

Closes #2528

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

Extract `backing-property-name` from `property-naming` rule. This allows users to disable this rule, but keep the `property-naming` rule in place.

 For `android_studio` code style the restrictions regarding the modifier of the correlated property or function is ignored entirely as the Android Kotlin Styleguide does not require it to be public.

 Closes #2528
@paul-dingemans paul-dingemans added this to the 1.2 milestone Feb 13, 2024
@paul-dingemans paul-dingemans merged commit a88a2e5 into master Feb 14, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2528-backing-property branch February 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract backing property from property-naming rule to separate rule
1 participant