Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string template to exceed max line length when it is the only element on a line #2480

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Allow string template to exceed max line length when it is the only element on a line

Closes #2453

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@paul-dingemans paul-dingemans added this to the 1.2 milestone Jan 1, 2024
@paul-dingemans
Copy link
Collaborator Author

A line containing a string and a trailing comma should not be reported to exceed max line length as. See example below:

throw SomeException(
    "A long exception message which exceeds the maximum line length and is followed by a (trailing) comma",
    e,
)
// or
throw SomeException(
    "A long exception message which exceeds the maximum line length and is followed by a (trailing) comma",
)

@paul-dingemans paul-dingemans merged commit 5d9c5bb into master Jan 23, 2024
22 checks passed
@paul-dingemans paul-dingemans deleted the 2453-max-line-length branch January 23, 2024 13:01
@paul-dingemans
Copy link
Collaborator Author

A line containing a string and a trailing comma should not be reported to exceed max line length as. See example below:

throw SomeException(
    "A long exception message which exceeds the maximum line length and is followed by a (trailing) comma",
    e,
)
// or
throw SomeException(
    "A long exception message which exceeds the maximum line length and is followed by a (trailing) comma",
)

Unfortunately, this has not been taken into account in this PR. Will be addressed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration to ignore max-line-length for strings
1 participant