Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BOM exclude list #2476

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Dec 31, 2023

Description

Simplify the code below:

val internalNonPublishableProjects: Set<String> by rootProject.extra
val excludeList = internalNonPublishableProjects + "ktlint-test-ruleset-provider-v2-deprecated"

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

@Goooler
Copy link
Contributor Author

Goooler commented Dec 31, 2023

diff ktlint-bom-1.1.0-SNAPSHOT.pom.before ktlint-bom-1.1.0-SNAPSHOT.pom.after
ktlint-bom-1.1.0-SNAPSHOT.pom.after

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.pinterest.ktlint</groupId>
  <artifactId>ktlint-bom</artifactId>
  <version>1.1.0-SNAPSHOT</version>
  <packaging>pom</packaging>
  <name>ktlint-bom</name>
  <description>An anti-bikeshedding Kotlin linter with built-in formatter.</description>
  <url>https://github.com/pinterest/ktlint</url>
  <licenses>
    <license>
      <name>MIT</name>
      <url>https://opensource.org/licenses/MIT</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>pinterest</id>
      <name>Pinterest, Inc.</name>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:git://github.com/pinterest/ktlint.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/pinterest/ktlint.git</developerConnection>
    <url>https://github.com/pinterest/ktlint</url>
  </scm>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-baseline</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-checkstyle</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-core</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-format</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-html</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-json</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-plain</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-plain-summary</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-reporter-sarif</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-cli-ruleset-core</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-logger</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-rule-engine</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-rule-engine-core</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-ruleset-standard</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>com.pinterest.ktlint</groupId>
        <artifactId>ktlint-test</artifactId>
        <version>1.1.0-SNAPSHOT</version>
      </dependency>
    </dependencies>
  </dependencyManagement>
</project>

@Goooler
Copy link
Contributor Author

Goooler commented Jan 2, 2024

@paul-dingemans Failure may be related to the project version, can you bump this to Snapshot first?

VERSION_NAME=1.1.0

@paul-dingemans
Copy link
Collaborator

@paul-dingemans Failure may be related to the project version, can you bump this to Snapshot first?

VERSION_NAME=1.1.0

Ouch, good catch. I did forget to apply the last step in the release process. I will update it and push the change to your branch once merged.

@paul-dingemans paul-dingemans added this to the 1.2 milestone Jan 2, 2024
@Goooler
Copy link
Contributor Author

Goooler commented Jan 3, 2024

Wrongly rebased.

@paul-dingemans paul-dingemans merged commit f7557d2 into pinterest:master Jan 23, 2024
11 checks passed
@Goooler Goooler deleted the simplify-bom-publishing branch January 23, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants