Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run argument-list-wrapping, class-signature and function-signature when comment rules are disabled #2466

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

paul-dingemans
Copy link
Collaborator

Description

Loosen dependencies on value-argument-comment, value-parameter-comment, type-argument-comment, and type-parameter-comment rules to be disabled

Run argument-list-wrapping, class-signature and function-signature when comment rules above are disabled.

Closes #2445

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

…ment`, `type-argument-comment`, and `type-parameter-comment` rules to be disabled

Run `argument-list-wrapping`, `class-signature` and `function-signature` when comment rules above are disabled.

Closes #2445
@paul-dingemans paul-dingemans added this to the 1.1.1 milestone Dec 26, 2023
@paul-dingemans paul-dingemans changed the title Run argument-list-wrapping, class-signature and function-signature when comment rules above are disabled Run argument-list-wrapping, class-signature and function-signature when comment rules are disabled Dec 27, 2023
@paul-dingemans paul-dingemans merged commit c1440aa into master Dec 27, 2023
22 checks passed
@paul-dingemans paul-dingemans deleted the 2445-argument-list-wrapping branch December 27, 2023 10:25
paul-dingemans added a commit to Goooler/ktlint that referenced this pull request Jan 2, 2024
…ment`, `type-argument-comment`, and `type-parameter-comment` rules to be disabled (pinterest#2466)

Run `argument-list-wrapping`, `class-signature` and `function-signature` when comment rules above are disabled.

Closes pinterest#2445
@vanniktech
Copy link
Contributor

  • Rule with id 'RuleId(value=standard:argument-list-wrapping)' requires rule with id 'RuleId(value=standard:value-argument-comment)' to be loaded

is fixed by this when running ktlint 1.1.0, right? I was trying to update and yet again I was being hit by Rules .. requires Rule .. to be loaded.

I can only agree with @eygraber's comment

@paul-dingemans
Copy link
Collaborator Author

is fixed by this when running ktlint 1.1.0, right?

No. As you can see, this issue is labeled with milestone 1.1.1 which is not yet released. You can use the snapshot if you like.

@vanniktech
Copy link
Contributor

Ah sorry I meant to say that I had gotten that exception when running 1.1.0 and is fixed with this PR (since this PR sits on top of the 1.1.0 version).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ktlint 1.1.0 doesn't respect disabled discouraged-comment-location rule in .editorconfig
2 participants