Issue#174 If then block should start with { and end with }
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokotaso
commented
Jun 16, 2018
| if (node.elementType == KtNodeTypes.THEN) { | ||
| assert(node.treeParent.elementType == KtNodeTypes.IF) | ||
| // Check Whether Block Element start with `{` | ||
| if (node.firstChildNode.firstChildNode.elementType != KtTokens.LBRACE) { |
There was a problem hiding this comment.
Is it needed nullable check?
yokotaso
commented
Jun 16, 2018
| } | ||
| } | ||
| // Check Whether Block Element end with `}` | ||
| if (node.lastChildNode.lastChildNode.elementType != KtTokens.RBRACE) { |
There was a problem hiding this comment.
Is it nullable check needed?
|
I'm sorry, Tomoya. I somehow managed to miss the notification about this PR. Merging in! 🙇♂️ |
|
@shyiko Thank you for merging PR! 🙇 |
This was referenced Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for developing wonderful tool!
I found this issue,
#174
And then, I tried to develop IfThenBlockWithCurlyBraceRule.
If you have a free time, Cloud you review it?