-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule to migrate away from ktlint-disable directives #2068
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 437a428 - Browse repository at this point
Copy the full SHA 437a428View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5031bad - Browse repository at this point
Copy the full SHA 5031badView commit details -
Improve trace logging by printing a lint error directly when it is em…
…itted The reports print the lint violations in which they occur in the source code. This is not necessarily the order in which they are detected and fixed. For debugging some type of problems, the latter order is important.
Configuration menu - View commit details
-
Copy full SHA for 675b708 - Browse repository at this point
Copy the full SHA 675b708View commit details -
Add rule to migrate ktlint-disable directives from comments to @Suppress
or @SuppressWarnings annotations Note that the SuppressionLocatorBuilder never ignore this rule as otherwise the suppression hint to ignore *all* rules would also ignore the rule which has to migrate this suppression hint. Closes #1947
Configuration menu - View commit details
-
Copy full SHA for 428d52e - Browse repository at this point
Copy the full SHA 428d52eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2422c8 - Browse repository at this point
Copy the full SHA e2422c8View commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fea7170 - Browse repository at this point
Copy the full SHA fea7170View commit details -
Configuration menu - View commit details
-
Copy full SHA for a973293 - Browse repository at this point
Copy the full SHA a973293View commit details -
Support annotations with named argument initialized with array (squar…
…ed bracket) notation
Configuration menu - View commit details
-
Copy full SHA for b84d8a8 - Browse repository at this point
Copy the full SHA b84d8a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a40c27e - Browse repository at this point
Copy the full SHA a40c27eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 11861fe - Browse repository at this point
Copy the full SHA 11861feView commit details
Commits on Jun 8, 2023
-
- Fix rule suppressions on a class initializer
- Merge rule suppressions that propagate to the same declaration annotation
Configuration menu - View commit details
-
Copy full SHA for ec099d5 - Browse repository at this point
Copy the full SHA ec099d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9ac65 - Browse repository at this point
Copy the full SHA ad9ac65View commit details
Commits on Jun 10, 2023
-
- Convert a top level block comment with a ktlint-disable directive t…
…o a file annotation. This also applies to directives which are placed as last comment before a top level class, fun or property (the kotlin embeddable compiler places such comments inside the ASTNode of the class, fun, property respectively. - Convert a block comment with a ktlint-disable directive to the first parent declaration or expression whenever a matching ktlint-enable directive is found as sibling inside the same parent node. - Do not autocorrect other block comments containing a ktlint-disable directive
Configuration menu - View commit details
-
Copy full SHA for 51a8b3e - Browse repository at this point
Copy the full SHA 51a8b3eView commit details
Commits on Jun 13, 2023
-
- Move KtlintSuppressionRule from standard ruleset to an internal rul…
…eset. In this way, it can be guaranteed that the rule runs for all API consumers, even the consumers that do not pass the standard rule providers - Do not process the ktlint-directives in the SuppressionLocatorBuilder, MaxLineLengthRule, NoSingleLineBlockCommentRule anymore - Fix offset problem with suppression annotation (see unit test MaxLineLengthRuleTest) - Fix problems in unit tests that referred to ktlint-directives which are no longer processed - Add "libs.logback" as runtime only dependency so that logging is visible in unit tests - Move checking of unknown rule ids from SuppressionLocatorBuilder to KtlintSuppressionRule so that normal lint violations are emitted instead of log message being printed.
Configuration menu - View commit details
-
Copy full SHA for 4b0b4e8 - Browse repository at this point
Copy the full SHA 4b0b4e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05bdaa2 - Browse repository at this point
Copy the full SHA 05bdaa2View commit details
Commits on Jun 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7fa8d3f - Browse repository at this point
Copy the full SHA 7fa8d3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5094565 - Browse repository at this point
Copy the full SHA 5094565View commit details -
Configuration menu - View commit details
-
Copy full SHA for a165c3a - Browse repository at this point
Copy the full SHA a165c3aView commit details -
Do not add an empty '@Suppress()' in case the ktlint rule id is unkno…
…wn or not loaded
Configuration menu - View commit details
-
Copy full SHA for be43f54 - Browse repository at this point
Copy the full SHA be43f54View commit details
Commits on Jun 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb8e15c - Browse repository at this point
Copy the full SHA cb8e15cView commit details -
Create suppress annotaion on class if ktlint-disable directive found …
…in primary constructor
Configuration menu - View commit details
-
Copy full SHA for d87ec58 - Browse repository at this point
Copy the full SHA d87ec58View commit details -
Promote a matching pair of ktlint-disable and ktlint-enable directive…
…s to the parent declaration in case the block contains multiple declarations or statements
Configuration menu - View commit details
-
Copy full SHA for e091cbc - Browse repository at this point
Copy the full SHA e091cbcView commit details -
Merge new ktlint rule suppression with existing suppression using a n…
…amed argument The named argument is replaced with the vararg notation in which the existing and new suppressions are merged
Configuration menu - View commit details
-
Copy full SHA for 1e2ffb9 - Browse repository at this point
Copy the full SHA 1e2ffb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 681d8ec - Browse repository at this point
Copy the full SHA 681d8ecView commit details -
Ensure that ktlint-suppression runs before any other rule
ktlint-disable directives have to be replaced with annotations before process other rules because the SuppressionLocatorBuilder is no longer processing those directives.
Configuration menu - View commit details
-
Copy full SHA for 76af1d1 - Browse repository at this point
Copy the full SHA 76af1d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73e3d4e - Browse repository at this point
Copy the full SHA 73e3d4eView commit details
Commits on Jun 25, 2023
-
Merge remote-tracking branch 'origin/master' into 1947-ktlint-disable
# Conflicts: # CHANGELOG.md # ktlint-rule-engine/src/main/kotlin/com/pinterest/ktlint/rule/engine/api/KtLintRuleEngine.kt
Configuration menu - View commit details
-
Copy full SHA for 4d5b734 - Browse repository at this point
Copy the full SHA 4d5b734View commit details
Commits on Jun 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37b6f3c - Browse repository at this point
Copy the full SHA 37b6f3cView commit details