Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KDOC indentation for tab indentation style #1263

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Oct 31, 2021

Fix #850

Description

The space before the continuation and end of a KDoc line is now preserved in case the tab indentation style is used.

Fixes #850

Checklist

  • tests are added
  • CHANGELOG.md is updated

Copy link
Collaborator

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please, add a changelog entry.
Also, in the future, please mention the issue number in the PR description, so it can be linked and closed accordingly.

@paul-dingemans
Copy link
Collaborator Author

LGTM, please, add a changelog entry. Also, in the future, please mention the issue number in the PR description, so it can be linked and closed accordingly.

Will add the changelog. I mentioned the issue number in the commit message and thought that was enough. I will mentioned it in the PR description next time as well.

@romtsn romtsn merged commit d3a58fe into pinterest:master Nov 2, 2021
@paul-dingemans paul-dingemans deleted the 850-indentation-kdoc branch February 5, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab indentation breaks KDoc comments
2 participants