ktlint --format should return error code if unable to autocorrect #2795
Comments
|
Normally the exit code will be set in case an unfixed error is found. I believe that in your case there is special situation in which multiple violations are found in the same file, which in the end do not change that file at all. In this case the exit code is not set properly. To be sure, I need to have a reproducable example. |
|
A single uncorrectable error will trigger the issue. The additional comment I made in #2794 with the .editorconfig should make it reproducible. |
paul-dingemans
added a commit
that referenced
this issue
Sep 18, 2024
…hanged In very rare cases it is possible that Lint violations are detected while formatting but that they have opposite effects and the file gets not altered at all. As the logging already might contain the message "Format was not able to resolve all violations which (theoretically) can be autocorrected in file ..." the format may not return with exit code 0. Closes #2795
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I ran into a bug in ktlint earlier today, which has motivated this feature request. I ran
ktlint --formatlocally, before submitting a pull request where the CI system runsktlint.ktlint --formatdid not fail locally (and I didn't look closely at the logs to see the warning), butktlinton CI did fail.Expected Behavior
When running
ktlint --format, any inability to autocorrect should be an error result code.Current Behavior
ktlint will print a warning, rather than returning an error result code.
Additional information
The text was updated successfully, but these errors were encountered: