Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting ktlint_disabled_rules enables running of experimental rules #1771

Closed
johnk-scalable opened this issue Jan 11, 2023 · 2 comments
Closed

Setting ktlint_disabled_rules enables running of experimental rules #1771

johnk-scalable opened this issue Jan 11, 2023 · 2 comments
Milestone
0.48.2

Comments

@johnk-scalable
Copy link
Contributor

johnk-scalable commented Jan 11, 2023 •
edited
Loading

Expected Behavior

  • Set ktlint_disabled_rules property to some value to disable some rules
  • Don't explicitly disable experimental rules
  • Run ktlint
  • Expected that only standard rulesets and custom rulesets are run (minus the rules that have been explicitly disabled)

Observed Behavior

standard rules, custom rules and experimental rules are run (minus the rules that have been explicitly disabled)

Steps to Reproduce

Your Environment

  • Version of ktlint used: 0.48.1
@johnk-scalable johnk-scalable mentioned this issue Jan 11, 2023
Merged
@paul-dingemans
Copy link
Collaborator

Please provide more information how to reproduce. Enclose ".editorconfig", command executed and log files produced with flag --log-level=debug.

@paul-dingemans
Copy link
Collaborator

Please provide more information how to reproduce. Enclose ".editorconfig", command executed and log files produced with flag --log-level=debug.

Nvm, just see your PR.

paul-dingemans added a commit to johnk-scalable/ktlint that referenced this issue Jan 15, 2023
@paul-dingemans
Do not enable the experimental rules by default when .editorconfig …
2a0fe07 
…properties `disabled_rules` or `ktlint_disabled_rules` are set

* Remove redundant test

Closes pinterest#1771
@paul-dingemans paul-dingemans added this to the 0.48.2 milestone Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.48.2
Development

No branches or pull requests
2 participants
@paul-dingemans @johnk-scalable