Skip to content

Commit

Permalink
Remove sdkman (#2693)
Browse files Browse the repository at this point in the history
Almost every release, publishing to sdkman resulted in failures. Only a few users seems to depend on it.

Closes #2692
  • Loading branch information
paul-dingemans committed Jun 11, 2024
1 parent 54bf3c0 commit 779a778
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 30 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/publish-release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,10 @@ jobs:
if: ${{ success() }}
run: echo "version=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_ENV

- name: Create zip for dependency managers
- name: Create zip for dependency manager(s)
if: ${{ success() }}
run: |
cd ktlint-cli/build/run
# Doing this for Homebrew and https://github.com/sdkman/sdkman-cli/wiki/Well-formed-SDK-archives
mkdir -p ktlint-${{ env.version }}/bin
cp ktlint ktlint-${{ env.version }}/bin
zip -rm ktlint-${{ env.version }}.zip ktlint-${{ env.version }}
Expand Down Expand Up @@ -79,14 +78,6 @@ jobs:
formula-path: Formula/k/ktlint.rb
download-url: https://github.com/pinterest/ktlint/releases/download/${{ env.version }}/ktlint-${{ env.version }}.zip

# - name: Release to sdkman
# if: ${{ success() }}
# env:
# SDKMAN_KEY: ${{ secrets.SDKMAN_KEY }}
# SDKMAN_TOKEN: ${{ secrets.SDKMAN_TOKEN }}
# SDKMAN_VERSION: ${{ env.version }}
# run: ./gradlew :ktlint-cli:sdkMajorRelease

- name: Update Release documentation
if: ${{ success() }}
run: |
Expand Down
5 changes: 0 additions & 5 deletions documentation/release-latest/docs/install/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/)
port install ktlint
```

Install with [SDKMAN! on macOS and Linux](https://sdkman.io/)
```sh
sdk install ktlint
```

On Arch Linux install package [ktlint <sup>AUR</sup>](https://aur.archlinux.org/packages/ktlint/).

## Command line usage
Expand Down
5 changes: 0 additions & 5 deletions documentation/snapshot/docs/install/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ Install with [MacPorts](https://www.macports.org/)
port install ktlint
```

Install with [SDKMAN! on macOS and Linux](https://sdkman.io/)
```sh
sdk install ktlint
```

On Arch Linux install package [ktlint <sup>AUR</sup>](https://aur.archlinux.org/packages/ktlint/).

## Command line usage
Expand Down
1 change: 0 additions & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ kotlinDev = "1.9.24"
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
checksum = "org.gradle.crypto.checksum:1.4.0"
shadow = "com.github.johnrengelman.shadow:8.1.1"
sdkman = "io.sdkman.vendors:3.0.0"
kotlinx-binary-compatibiltiy-validator = "org.jetbrains.kotlinx.binary-compatibility-validator:0.14.0"

[libraries]
Expand Down
9 changes: 0 additions & 9 deletions ktlint-cli/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ plugins {
id("ktlint-publication-library")
alias(libs.plugins.shadow)
alias(libs.plugins.checksum)
alias(libs.plugins.sdkman)
signing
}

Expand Down Expand Up @@ -164,11 +163,3 @@ tasks.withType<Test>().configureEach {
systemProperty("ktlint-version", ktlintVersion)
}
}

sdkman {
val sdkmanVersion = providers.environmentVariable("SDKMAN_VERSION").orElse(project.version.toString())
candidate = "ktlint"
version = sdkmanVersion
url = "https://github.com/pinterest/ktlint/releases/download/$sdkmanVersion/ktlint-$sdkmanVersion.zip"
hashtag = "ktlint"
}

0 comments on commit 779a778

Please sign in to comment.