Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spm integration on regular Xcode project #586

Merged
merged 5 commits into from
Jan 6, 2021
Merged

Fixed spm integration on regular Xcode project #586

merged 5 commits into from
Jan 6, 2021

Conversation

3a4oT
Copy link
Contributor

@3a4oT 3a4oT commented Nov 17, 2020

  • without this change project itself can be built as spm package, but failed to do so when you integrate it as a dependency via Xcode.

@3a4oT
Copy link
Contributor Author

3a4oT commented Nov 17, 2020

Will appreciate a new release if possible :) There is a similar PR fo the pinterest/PINCache#301
In general, spm/cocopods/xcode/carthage support is a little mind-blowing :)
cc @garrettmoon

@3a4oT 3a4oT mentioned this pull request Nov 19, 2020
Open
3 tasks
@garrettmoon
Copy link
Collaborator

Thanks for putting this up! I hate to ask, but would you mind updating the CI test to ensure that SPM works when integrating into a project?

@3a4oT
Copy link
Contributor Author

3a4oT commented Nov 19, 2020

Yes sir! Will add it to my list.

garrettmoon
garrettmoon approved these changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for putting this up, greatly appreciated!

@garrettmoon garrettmoon merged commit 543c2bc into pinterest:master Jan 6, 2021
@mthole
Copy link

mthole commented Apr 8, 2021

Can we get a release with this in it, please? @garrettmoon

@mthole mthole mentioned this pull request Apr 16, 2021
Open
@Ektris
Copy link

Ektris commented Aug 24, 2021

Going to ask as well, can we please get a release for these fixes? @garrettmoon

annomusa added a commit to annomusa/PINRemoteImage that referenced this pull request Dec 17, 2021
@annomusa
Merge branch 'master-pinremoteimage' into non-webp
5e5a69b 
* master-pinremoteimage:
  Disable asserts in release builds when using Swift Package Manager
  unarchiveObjectWithData: and archivedDataWithRootObject: are deprecated (pinterest#610)
  update comment
  Set cachePolicy accordingly when PINRemoteImageManagerDownloadOptionsIgnoreCache is provided
  Decode WebP images directly into a buffer Core Animation likes (pinterest#600)
  Xcode 12.5 / SPM - Add missing headers to fix build errors with SPM and Xcode 12.5 (pinterest#597)
  Fixed spm  integration on regular Xcode project (pinterest#586)
  Fix PINRemoteImageManager.h Close Comment Formatting (pinterest#594)
  Fix typo in PINRemoteImageManager.html (pinterest#593)
  Carthage is broken on Xcode 12 (pinterest#584)
  Update podspec to match release
  Hopefully fix publish for real this time...

# Conflicts:
#	Package.swift
Lilfaen pushed a commit to Lilfaen/PINRemoteImage that referenced this pull request Apr 20, 2023
@3a4oT @Lilfaen
Fixed spm integration on regular Xcode project (pinterest#586)
6ef8dd1 
* work with imports.

* fixed imports for Xcode spa consumers

* added exmple project

* carthage workaround

* updated CI
# Conflicts:
#	.github/workflows/ci.yaml
#	Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettmoon garrettmoon garrettmoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3a4oT @garrettmoon @mthole @Ektris