Skip to content

Commit ef10415

Browse files
authored
Upgrade pin cache fix warnings (#506)
* Modernize project and fix some warnings * Upgrade PINCache, fix warnings and re-enable warning check * Update carthage make command * Remove duplicate dependencies
1 parent 69891fd commit ef10415

36 files changed

+215
-154
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
- [new] Add PINRemoteImageManagerConfiguration configuration object [#492](https://github.com/pinterest/PINRemoteImage/pull/492) [rqueue](https://github.com/rqueue)
44

55
## 3.0.0 Beta 14
6+
- [fixed] Re-enable warnings check [#506](https://github.com/pinterest/PINRemoteImage/pull/506) [garrettmoon](https://github.com/garrettmoon)
67
- [new] Allow use of NSURLCache via a custom NSURLSession [#477](https://github.com/pinterest/PINRemoteImage/pull/477) [wiseoldduck](https://github.com/wiseoldduck)
78
- [new] Respect Cache-Control and Expires headers if the cache supports TTL. [#462](https://github.com/pinterest/PINRemoteImage/pull/462) [wiseoldduck](https://github.com/wiseoldduck)
89
- [new] Updated to latest PINCache beta 7. [#461](https://github.com/pinterest/PINRemoteImage/pull/461) [wiseoldduck](https://github.com/wiseoldduck)

Cartfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
git "https://chromium.googlesource.com/webm/libwebp" "v0.6.0"
2-
github "pinterest/PINCache" "3.0.1-beta.7"
1+
github "pinterest/PINCache" "3.0.1-beta.8"
32
github "pinterest/PINOperation"

Cartfile.resolved

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
git "https://chromium.googlesource.com/webm/libwebp" "v0.6.0"
2-
github "pinterest/PINCache" "3.0.1-beta.7"
3-
github "pinterest/PINOperation" "1.1.1"
1+
github "pinterest/PINCache" "3.0.1-beta.8"
2+
github "pinterest/PINOperation" "1.1.2"

Carthage/Checkouts/PINCache/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
* Add your own contributions to the next release on the line below this with your name.
44

5+
## 3.0.1 -- Beta 8
6+
- [fix] Initing PINCache with TTL enabled should enable TTL on PINMemoryCache. [#246](https://github.com/pinterest/PINCache/pull/246)
7+
- [performance] Return TTL cache objects without waiting for all metadata to be read. [#228](https://github.com/pinterest/PINCache/pull/228)
8+
- [performance] Memory cache now performs some tasks such as trimming and removing experied objects with low priority. [#234](https://github.com/pinterest/PINCache/pull/234)
9+
510
## 3.0.1 -- Beta 7
611
- [fix] Fix up warnings and upgrade to PINOperation 1.1.1: [#213](https://github.com/pinterest/PINCache/pull/213)
712
- [performance] Reduce locking churn in cleanup methods. [#212](https://github.com/pinterest/PINCache/pull/212)

Carthage/Checkouts/PINCache/PINCache.podspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Pod::Spec.new do |s|
22
s.name = 'PINCache'
3-
s.version = '3.0.1-beta.7'
3+
s.version = '3.0.1-beta.8'
44
s.homepage = 'https://github.com/pinterest/PINCache'
55
s.summary = 'Fast, thread safe, parallel object cache for iOS and OS X.'
66
s.authors = { 'Garrett Moon' => 'garrett@pinterest.com', 'Justin Ouellette' => 'jstn@tumblr.com' }
@@ -11,7 +11,7 @@ Pod::Spec.new do |s|
1111
s.ios.weak_frameworks = 'UIKit'
1212
s.osx.weak_frameworks = 'AppKit'
1313
s.ios.deployment_target = '8.0'
14-
s.osx.deployment_target = '10.8'
14+
s.osx.deployment_target = '10.11'
1515
s.tvos.deployment_target = '9.0'
1616
s.watchos.deployment_target = '2.0'
1717
pch_PIN = <<-EOS

Carthage/Checkouts/PINCache/PINCache.xcodeproj/project.pbxproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@
534534
developmentRegion = English;
535535
hasScannedForEncodings = 0;
536536
knownRegions = (
537-
en,
537+
English,
538538
);
539539
mainGroup = CC0105A71E271A1600890935;
540540
productRefGroup = CC0105B21E271A1600890935 /* Products */;
@@ -760,6 +760,7 @@
760760
CLANG_WARN_CONSTANT_CONVERSION = YES;
761761
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
762762
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
763+
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
763764
CLANG_WARN_EMPTY_BODY = YES;
764765
CLANG_WARN_ENUM_CONVERSION = YES;
765766
CLANG_WARN_INFINITE_RECURSION = YES;
@@ -819,6 +820,7 @@
819820
CLANG_WARN_CONSTANT_CONVERSION = YES;
820821
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
821822
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
823+
CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
822824
CLANG_WARN_EMPTY_BODY = YES;
823825
CLANG_WARN_ENUM_CONVERSION = YES;
824826
CLANG_WARN_INFINITE_RECURSION = YES;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
3+
<plist version="1.0">
4+
<dict>
5+
<key>IDEDidComputeMac32BitWarning</key>
6+
<true/>
7+
</dict>
8+
</plist>

Carthage/Checkouts/PINCache/PINCache.xcodeproj/xcshareddata/xcschemes/PINCache-macOS.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0930"
3+
LastUpgradeVersion = "1020"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

Carthage/Checkouts/PINCache/PINCache.xcodeproj/xcshareddata/xcschemes/PINCache-tvOS.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0930"
3+
LastUpgradeVersion = "1020"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

Carthage/Checkouts/PINCache/PINCache.xcodeproj/xcshareddata/xcschemes/PINCache.xcscheme

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0930"
3+
LastUpgradeVersion = "1020"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"

0 commit comments

Comments
 (0)