Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept level in capitals #2034

Merged
merged 2 commits into from
Aug 31, 2024
Merged

feat: accept level in capitals #2034

merged 2 commits into from
Aug 31, 2024

Conversation

balaji-atoa
Copy link
Contributor

💬BASED ON:

#2022 (comment)

🚀UPDATES:

  • converted level to lower case if passed in capitals.

✅ Added UnitTests.

@balaji-atoa
Copy link
Contributor Author

balaji-atoa commented Aug 23, 2024

HELP NEEDED! @jsumners

  • Tried reproducing the same in my local by using the exact environment versions for node and npm. but, this passed.
    image

  • ran npm run test-ci & it passed in my local.

$ npm run test-ci

> pino@9.3.2 test-ci
> npm run lint && npm run transpile && tap --ts --no-check-coverage --coverage-report=lcovonly && npm run test-types


> pino@9.3.2 lint
> eslint .


> pino@9.3.2 transpile
> node ./test/fixtures/ts/transpile.cjs

​ SKIP ​ test/broken-pipe.test.js
 ~ skipping on windows

​ SKIP ​ TAP
 ~ test/browser-early-console-freeze.test.js

​ SKIP ​ test/http.test.js
 ~ http request support via serializer without request connection

​ SKIP ​ test/transport/module-link.test.js
 ~ pino.transport with package

​ SKIP ​ test/transport/module-link.test.js                                                                                                                     
 ~ pino.transport with package as a target                                                                                                                      

​ SKIP ​ test/transport/module-link.test.js
 ~ pino({ transport })

​ SKIP ​ test/transport/module-link.test.js
 ~ pino({ transport }) from a wrapped dependency

​ SKIP ​ test/broken-pipe.test.js 1 skip of 1 3.142ms
 ~ skipping on windows

​ SKIP ​ test/browser-early-console-freeze.test.js 2s
​ SKIP ​ test/http.test.js 1 skip of 16 155.235ms
 ~ http request support via serializer without request connection

​ SKIP ​ test/transport/module-link.test.js 4 skip of 4 19.466ms
 ~ pino.transport with package
 ~ pino.transport with package as a target
 ~ pino({ transport })
 ~ pino({ transport }) from a wrapped dependency

Suites:   ​44 passed​, ​1 skip​, ​45 of 45 completed​
Asserts:  ​​​1334 passed​, ​7 skip​, ​of 1341​

> pino@9.3.2 test-types
> tsc && tsd && ts-node test/types/pino.ts

[16:39:30.633] CUSTOMDEBUG (9012): test3
[16:39:30.640] INFO (9012): test4
[16:39:30.641] CUSTOMERROR (9012): test5
[16:39:30.642] CUSTOMNETWORK (9012): test6
[16:39:30.622] INFO (9012): test2
    some: "bindings"
[16:39:30.625] INFO (9012): test2
[16:39:30.626] INFO (9012): test2

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from jsumners August 25, 2024 13:32
@mcollina mcollina merged commit 74fc0db into pinojs:main Aug 31, 2024
12 checks passed
alexandresoro pushed a commit to alexandresoro/ouca that referenced this pull request Sep 4, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [pino](https://getpino.io) ([source](https://github.com/pinojs/pino)) | dependencies | minor | [`9.3.2` -> `9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) |

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v9.4.0`](https://github.com/pinojs/pino/releases/tag/v9.4.0)

[Compare Source](pinojs/pino@v9.3.2...v9.4.0)

#### What's Changed

-   Drop failing pnpm tests by [@&#8203;mcollina](https://github.com/mcollina) in pinojs/pino#2015
-   Add bun plugin link to docs by [@&#8203;vktrl](https://github.com/vktrl) in pinojs/pino#2016
-   build(deps-dev): bump [@&#8203;types/node](https://github.com/types/node) from 20.14.13 to 22.0.0 by [@&#8203;dependabot](https://github.com/dependabot) in pinojs/pino#2017
-   docs: Update transports.md by [@&#8203;Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) in pinojs/pino#2027
-   build(deps-dev): bump [@&#8203;yao-pkg/pkg](https://github.com/yao-pkg/pkg) from 5.12.0 to 5.12.1 by [@&#8203;dependabot](https://github.com/dependabot) in pinojs/pino#2031
-   feat(types): forbid using default log fn when custom only used ([#&#8203;1998](pinojs/pino#1998)) by [@&#8203;chernodub](https://github.com/chernodub) in pinojs/pino#1999
-   feat: accept level in capitals by [@&#8203;balaji-atoa](https://github.com/balaji-atoa) in pinojs/pino#2034

#### New Contributors

-   [@&#8203;vktrl](https://github.com/vktrl) made their first contribution in pinojs/pino#2016
-   [@&#8203;Imgodmaoyouknow](https://github.com/Imgodmaoyouknow) made their first contribution in pinojs/pino#2027
-   [@&#8203;chernodub](https://github.com/chernodub) made their first contribution in pinojs/pino#1999
-   [@&#8203;balaji-atoa](https://github.com/balaji-atoa) made their first contribution in pinojs/pino#2034

**Full Changelog**: pinojs/pino@v9.3.2...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC42NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNjQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/79
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
renovate bot referenced this pull request in redwoodjs/redwood Sep 9, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://redirect.github.com/pinojs/pino)) | [`9.3.2` ->
`9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

###
[`v9.4.0`](https://redirect.github.com/pinojs/pino/releases/tag/v9.4.0)

[Compare
Source](https://redirect.github.com/pinojs/pino/compare/v9.3.2...v9.4.0)

#### What's Changed

- Drop failing pnpm tests by
[@&#8203;mcollina](https://redirect.github.com/mcollina) in
[https://github.com/pinojs/pino/pull/2015](https://redirect.github.com/pinojs/pino/pull/2015)
- Add bun plugin link to docs by
[@&#8203;vktrl](https://redirect.github.com/vktrl) in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- build(deps-dev): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.13 to 22.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2017](https://redirect.github.com/pinojs/pino/pull/2017)
- docs: Update transports.md by
[@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- build(deps-dev): bump
[@&#8203;yao-pkg/pkg](https://redirect.github.com/yao-pkg/pkg) from
5.12.0 to 5.12.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2031](https://redirect.github.com/pinojs/pino/pull/2031)
- feat(types): forbid using default log fn when custom only used
([#&#8203;1998](https://redirect.github.com/pinojs/pino/issues/1998)) by
[@&#8203;chernodub](https://redirect.github.com/chernodub) in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- feat: accept level in capitals by
[@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

#### New Contributors

- [@&#8203;vktrl](https://redirect.github.com/vktrl) made their first
contribution in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- [@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
made their first contribution in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- [@&#8203;chernodub](https://redirect.github.com/chernodub) made their
first contribution in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- [@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) made
their first contribution in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

**Full Changelog**:
pinojs/pino@v9.3.2...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM referenced this pull request in redwoodjs/redwood Sep 10, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://redirect.github.com/pinojs/pino)) | [`9.3.2` ->
`9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

###
[`v9.4.0`](https://redirect.github.com/pinojs/pino/releases/tag/v9.4.0)

[Compare
Source](https://redirect.github.com/pinojs/pino/compare/v9.3.2...v9.4.0)

#### What's Changed

- Drop failing pnpm tests by
[@&#8203;mcollina](https://redirect.github.com/mcollina) in
[https://github.com/pinojs/pino/pull/2015](https://redirect.github.com/pinojs/pino/pull/2015)
- Add bun plugin link to docs by
[@&#8203;vktrl](https://redirect.github.com/vktrl) in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- build(deps-dev): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.13 to 22.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2017](https://redirect.github.com/pinojs/pino/pull/2017)
- docs: Update transports.md by
[@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- build(deps-dev): bump
[@&#8203;yao-pkg/pkg](https://redirect.github.com/yao-pkg/pkg) from
5.12.0 to 5.12.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2031](https://redirect.github.com/pinojs/pino/pull/2031)
- feat(types): forbid using default log fn when custom only used
([#&#8203;1998](https://redirect.github.com/pinojs/pino/issues/1998)) by
[@&#8203;chernodub](https://redirect.github.com/chernodub) in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- feat: accept level in capitals by
[@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

#### New Contributors

- [@&#8203;vktrl](https://redirect.github.com/vktrl) made their first
contribution in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- [@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
made their first contribution in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- [@&#8203;chernodub](https://redirect.github.com/chernodub) made their
first contribution in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- [@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) made
their first contribution in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

**Full Changelog**:
pinojs/pino@v9.3.2...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot referenced this pull request in rustymotors/server Sep 16, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://redirect.github.com/pinojs/pino)) | [`^9.3.2` ->
`^9.4.0`](https://renovatebot.com/diffs/npm/pino/9.3.2/9.4.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/9.3.2/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [pino](https://getpino.io)
([source](https://redirect.github.com/pinojs/pino)) | [`^9.3.2` ->
`^9.4.0`](https://renovatebot.com/diffs/npm/pino/8.17.1/9.4.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.17.1/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.17.1/9.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

###
[`v9.4.0`](https://redirect.github.com/pinojs/pino/releases/tag/v9.4.0)

[Compare
Source](https://redirect.github.com/pinojs/pino/compare/v9.3.2...v9.4.0)

#### What's Changed

- Drop failing pnpm tests by
[@&#8203;mcollina](https://redirect.github.com/mcollina) in
[https://github.com/pinojs/pino/pull/2015](https://redirect.github.com/pinojs/pino/pull/2015)
- Add bun plugin link to docs by
[@&#8203;vktrl](https://redirect.github.com/vktrl) in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- build(deps-dev): bump
[@&#8203;types/node](https://redirect.github.com/types/node) from
20.14.13 to 22.0.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2017](https://redirect.github.com/pinojs/pino/pull/2017)
- docs: Update transports.md by
[@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- build(deps-dev): bump
[@&#8203;yao-pkg/pkg](https://redirect.github.com/yao-pkg/pkg) from
5.12.0 to 5.12.1 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/pinojs/pino/pull/2031](https://redirect.github.com/pinojs/pino/pull/2031)
- feat(types): forbid using default log fn when custom only used
([#&#8203;1998](https://redirect.github.com/pinojs/pino/issues/1998)) by
[@&#8203;chernodub](https://redirect.github.com/chernodub) in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- feat: accept level in capitals by
[@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

#### New Contributors

- [@&#8203;vktrl](https://redirect.github.com/vktrl) made their first
contribution in
[https://github.com/pinojs/pino/pull/2016](https://redirect.github.com/pinojs/pino/pull/2016)
- [@&#8203;Imgodmaoyouknow](https://redirect.github.com/Imgodmaoyouknow)
made their first contribution in
[https://github.com/pinojs/pino/pull/2027](https://redirect.github.com/pinojs/pino/pull/2027)
- [@&#8203;chernodub](https://redirect.github.com/chernodub) made their
first contribution in
[https://github.com/pinojs/pino/pull/1999](https://redirect.github.com/pinojs/pino/pull/1999)
- [@&#8203;balaji-atoa](https://redirect.github.com/balaji-atoa) made
their first contribution in
[https://github.com/pinojs/pino/pull/2034](https://redirect.github.com/pinojs/pino/pull/2034)

**Full Changelog**:
pinojs/pino@v9.3.2...v9.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/rustymotors/server).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldiIsImxhYmVscyI6W119-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants