Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nesting of level when applying a level formatter #1967

Closed
wants to merge 1 commit into from
Closed

fix nesting of level when applying a level formatter #1967

wants to merge 1 commit into from

Conversation

timtrense-leadec
Copy link

fixes #1966

probably needs a run of the test suite still

jsumners
jsumners requested changes May 6, 2024
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that illustrates the problem.

@timtrense-leadec
Copy link
Author

Superseded by #1971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

browser.formatters.level does not inline attributes into message anymore
2 participants
@timtrense-leadec @jsumners