-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send config to transports on init #1930
Merged
mcollina
merged 3 commits into
pinojs:master
from
10xLaCroixDrinker:feature/send-config-to-transports
Apr 24, 2024
Merged
feat: send config to transports on init #1930
mcollina
merged 3 commits into
pinojs:master
from
10xLaCroixDrinker:feature/send-config-to-transports
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2024
@10xLaCroixDrinker can you add an integration test that verifies all 3 pieces works correctly? Thanks |
Added in 18cb39d |
mcollina
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merged
renovate bot
referenced
this pull request
in fwouts/previewjs
Apr 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.20.0` -> `^8.21.0`](https://renovatebot.com/diffs/npm/pino/8.20.0/8.21.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.20.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.20.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.21.0`](https://togithub.com/pinojs/pino/releases/tag/v8.21.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.20.0...v8.21.0) #### What's Changed - docs: add a section about pino-logfmt [#​1879](https://togithub.com/pinojs/pino/issues/1879) by [@​botflux](https://togithub.com/botflux) in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - Docs: Separate ecosystem lists by [@​EstebanDalelR](https://togithub.com/EstebanDalelR) in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) - feat: send config to transports on init by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1930](https://togithub.com/pinojs/pino/pull/1930) #### New Contributors - [@​botflux](https://togithub.com/botflux) made their first contribution in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - [@​EstebanDalelR](https://togithub.com/EstebanDalelR) made their first contribution in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) **Full Changelog**: pinojs/pino@v8.20.0...v8.21.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
renovate bot
referenced
this pull request
in redwoodjs/redwood
May 16, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.19.0` -> `8.21.0`](https://renovatebot.com/diffs/npm/pino/8.19.0/8.21.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.19.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.19.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.21.0`](https://togithub.com/pinojs/pino/releases/tag/v8.21.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.20.0...v8.21.0) #### What's Changed - docs: add a section about pino-logfmt [#​1879](https://togithub.com/pinojs/pino/issues/1879) by [@​botflux](https://togithub.com/botflux) in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - Docs: Separate ecosystem lists by [@​EstebanDalelR](https://togithub.com/EstebanDalelR) in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) - feat: send config to transports on init by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1930](https://togithub.com/pinojs/pino/pull/1930) #### New Contributors - [@​botflux](https://togithub.com/botflux) made their first contribution in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - [@​EstebanDalelR](https://togithub.com/EstebanDalelR) made their first contribution in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) **Full Changelog**: pinojs/pino@v8.20.0...v8.21.0 ### [`v8.20.0`](https://togithub.com/pinojs/pino/compare/v8.19.0...v8.20.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.19.0...v8.20.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM
referenced
this pull request
in redwoodjs/redwood
May 17, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.19.0` -> `8.21.0`](https://renovatebot.com/diffs/npm/pino/8.19.0/8.21.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.19.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.19.0/8.21.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.21.0`](https://togithub.com/pinojs/pino/releases/tag/v8.21.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.20.0...v8.21.0) #### What's Changed - docs: add a section about pino-logfmt [#​1879](https://togithub.com/pinojs/pino/issues/1879) by [@​botflux](https://togithub.com/botflux) in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - Docs: Separate ecosystem lists by [@​EstebanDalelR](https://togithub.com/EstebanDalelR) in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) - feat: send config to transports on init by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1930](https://togithub.com/pinojs/pino/pull/1930) #### New Contributors - [@​botflux](https://togithub.com/botflux) made their first contribution in [https://github.com/pinojs/pino/pull/1941](https://togithub.com/pinojs/pino/pull/1941) - [@​EstebanDalelR](https://togithub.com/EstebanDalelR) made their first contribution in [https://github.com/pinojs/pino/pull/1942](https://togithub.com/pinojs/pino/pull/1942) **Full Changelog**: pinojs/pino@v8.20.0...v8.21.0 ### [`v8.20.0`](https://togithub.com/pinojs/pino/compare/v8.19.0...v8.20.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.19.0...v8.20.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced May 23, 2024
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2 of 3 for #1925
Relates to pinojs/thread-stream#145
Relates to pinojs/pino-abstract-transport#90
Include
pinoWillSendConfig
in workerData so that transports using the config know to wait, and emit a message event withPINO_CONFIG
on the stream when initializing Pino