MentorCity V.1.1.0 #22
Conversation
User auth api
Select attributes that are needed in JSON response
…ssosciations Setup models controllers and assosciations
Add endpoint for reservation
Api documentation
Add readme
There was a problem hiding this comment.
Hi @Lizdev-05,
Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation, but you are almost there!
To highlight:
- APIis is working well✔️
- Good readme ✔️
You are really close to finishing the Microverse program!! Keep it up! 👍👍👍
After implementing the requested changes, please submit another review request. ♻️
Check the comments under the review.
I strongly recommend you take them into account as they can improve your final evaluation.
Cheers and Happy coding!👏👏👏
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the previous reviews unless it is requested otherwise.
| class AddSubjectToReservations < ActiveRecord::Migration[7.0] | ||
| def change | ||
| add_column :reservations, :subject, :string | ||
| end | ||
| end |
There was a problem hiding this comment.
- For a new user, it is impossible to run the migrations. That is why it is never recommended to edit the migrations after they are already done:
Explanation
Your project runs well on your machine because the migrations have been already implemented. Even if the migration files have any new errors, your database is untouched.
For a new user who needs to apply the migrations for the first time, this is a whole different story. They will fail.
Remember that the final evaluator needs to be able to run the project without any hassle.
Tips and Extra help
Run this command: rake db:migrate VERSION=0. This will undo all the migrations. After that, you can apply one by one and skip the problematic one. The error message should give you a good idea of what is the problem.
Then, reseed the database and it will be fixed . 💪
There was a problem hiding this comment.
Hi @Meltrust , I have followed the above steps and redid the migrations 🙏
README.md
Outdated
| ### Run tests | ||
|
|
||
| To run tests, run the following command: | ||
|
|
||
| ```sh | ||
| rspec spec/integration | ||
| ``` |
There was a problem hiding this comment.
- When I run your tests according to your instructions, I get this:
If your tests should not be run like that, kindly change the instructions. If one or more of your tests are failing, kindly fix them to ensure the integrity of your app.
There was a problem hiding this comment.
hi @Meltrust , I have added the correct steps to run tests
README.md
Outdated
| ## 📝 License <a name="license"></a> | ||
|
|
||
| This project is [MIT](./LICENSE) licensed. | ||
|
|
||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> |
There was a problem hiding this comment.
- On the "License" section of your readme, the link is broken because it points to a file that does not exist in your project.
Tips and extra help
Go here, grab the MIT.md file from that repo, paste it on the root of your project, and link to it in the "License" section of your readme.
That way, your app will be well documented 💪
…ck_end into hotfix
Hi @Lizdev-05,Wow, you did it 🎉Thank you for the changes implemented 💪 🥇 ㊗️Unless you want to add more features, go ahead to your final presentation ⏩ ⏩ ⏩You are about to finish the Microverse program. You have come a long way!!!Good luck in the software industry!! I'll see you there. ✨Congratulations!!!!!! 🎉To highlight
Cheers and Happy coding!👏👏👏 |
fix kanban board path
|
tHANK YOU @Meltrust 🙏 |
Hi there 👋🏻
Thanks for taking the time to review the project. Here are some things important to note about it:
Frontend Link
You can find the link for the frontend project pinkmoon25/Book_an_appointment_front_end#9
Now into the project...
This project was done following git-flow, for which we have different pull requests, each of them with specific information about each feature. You can refer to them below
Final notes 📔
Is expected that this project meets the requirements. Please let me know if anything is left to be done or can be improved. Again, thanks for the review.