Fix memory leak in rtl_tcp on TCP client close #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this can get merged? |
pinkavaj
reviewed
Jan 5, 2025
| static int llbuf_num = 500; | ||
|
|
||
| static volatile int do_exit = 0; | ||
| atomic_bool do_exit = false; |
There was a problem hiding this comment.
Why the static is remove? It looks like the variable is still only used within this file.
|
|
||
| static volatile int do_exit = 0; | ||
| atomic_bool do_exit = false; | ||
| atomic_bool conn_reset = false; |
|
Btw it might be worth send this to https://github.com/librtlsdr/librtlsdr (I use it as an upstream, so the update will get here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset fixes two issues I observed in
rtl_tcp:do_exitand introducing a newconn_resetboolean.To facilitate the latter change, this binary requires C11 to allow the use of atomic types.