Fix: Handle case where image markdown insert passes 1000 chars #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill exceed max length + add error
steven-fox
approved these changes
Sep 27, 2024
MrPunyapal
reviewed
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have an edge case, where if the user has a post that is close to the max content length & they upload an image, there is no current validation, which allows the user to exceed the content limit.
This PR will add a check to ensure that the image being inserted as markdown won't pass the content limit & the image preview will still be available for the user to click and try to re-insert the markdown once the post has been shortened.
Closes #508
Screen.Recording.2024-09-27.at.11.28.02.AM.mov