Fix: #582 Incorrect text to link parsing #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LOL This is a funny incorrect parsing from production just now. 
... (later) and another one I just saw |
nunomaduro
deleted the
582-incorrect-text-to-link-parsing-for-bladephp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #582
This PR updates the
LinkProviderParsableto only linkify text that is a http(s) or email string.Important: Before this PR, text like
example.comwould be converted to a link. After this PR, this will no longer happen.example.comandblade.phpcurrently match the regex pattern, so I fixed #582 by simply looking for the string to start with http(s) or to be an email match.If we want to retain that example.com should linkify functionality, we will have to change the parsing logic to identify valid top-level domains, I guess? That's like 400+ possible values so I didn't go that route for this quick change.
I'll leave it up to you guys to decide what's most important.