Fix: Add addition validation rules for max size & ratio #504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional validation constraints to prevent people abusing the image uploading on posts.
We recently added a Lightbox & had to adjust the CSS to handle scrolling for edge cases of really long images.
The issue was, we should be preventing any image that is above the aspect ratio of 2:5, as it becomes far to long for the feed. This will solve this problem, so I have changed the Lightbox css to not require scrolling also as it will be responsive, this is the maximum size aspect ratio it will allow, like so:
This is still a really large image so I it will just prevent issues from people abusing the system with very tall images that ruin the feed & light box.
NOTE: I have not added a custom validation rule, I have temporarily used a closure, as I have submitted a PR to the framework to add maxRatio, minRatio & ratioRange on the Dimension ruleset - so we will be able to easily switch to that.
laravel/framework#52482