For you to Following #494
For you to Following #494
Conversation
|
@nunomaduro @MrPunyapal please have a look at this. |
| @@ -8,10 +8,10 @@ | |||
| use App\Models\User; | |||
| use Illuminate\Database\Eloquent\Builder; | |||
|
|
|||
| final readonly class QuestionsForYouFeed | |||
| final readonly class QuestionsFollowingFeed | |||
There was a problem hiding this comment.
Hey, it's not just about renaming file names.
Check queries in this file.
You need to change logic here too.
It must only show the posts from users which are followed by the current user.
There was a problem hiding this comment.
I hear you, but the logic for follower and following is not touched at all. That makes the need to change in query, not required.
Its just the label and files names which will be impacted. At DB level there is no change hence no update in Query.
what am I missing ?
There was a problem hiding this comment.
it should show what exactly the following means.
There was a problem hiding this comment.
can you please elaborate for better understanding ? Right now the "for you" section get all the questions which are suppose to be "Following".
There was a problem hiding this comment.
Check the query.
It's not showing posts from the following of users.
It has some other logic.
It should show posts where the user is following $question->to.
There was a problem hiding this comment.
thanks for the input @ojessecruz . I got that part, but the current query is doing exactly the same. That is what i did not undertand. What are the changes required.
The for you page right now shows the post from the people you are are following. The last line in the query (image above) shows the same. This is what I am confused about.
There was a problem hiding this comment.
When you see orWhere that means it's not just including following posts it has some extra sutff that we need to remove 🙂
There was a problem hiding this comment.
Ohhh.. This is what you meant. You meant only the post from followings. Right now it also shows the liked and replied posts by the following. Thanks for the explanation. I'll make the update tomorrow.
Thanks @MrPunyapal
There was a problem hiding this comment.
@msamgan are you there?
There was a problem hiding this comment.
yes, was preoccupied in some family matter.
Will give you an updated PR by tomorrow...
#453