Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: easy follow #470

Merged
merged 12 commits into from
Sep 21, 2024
Merged

Feat: easy follow #470

merged 12 commits into from
Sep 21, 2024

Conversation

MrPunyapal
Copy link
Collaborator

@MrPunyapal MrPunyapal commented Aug 2, 2024 •
edited
Loading

It adds follow/unfollow buttons to the following and followers lists.
image
image

White mode:
image

@MrPunyapal MrPunyapal mentioned this pull request Aug 4, 2024
Closed
@msamgan msamgan mentioned this pull request Aug 4, 2024
Closed
@MrPunyapal MrPunyapal changed the title [WIP] Feat: easy follow Feat: easy follow Aug 4, 2024
@MrPunyapal MrPunyapal linked an issue Aug 4, 2024 that may be closed by this pull request
Improve following users #439
Closed
@steven-fox
Copy link
Collaborator

steven-fox commented Aug 4, 2024 •
edited
Loading

Looks like great work, Punyapal!

I’m still not entirely sold on adding the easy follow button to the posts on a feed, personally. Not adamantly against it, just not fully loving it haha.

Would it make sense to split this PR into 2? One for the easy follow on a person’s “followers” and “following” modals, and then a separate one for the feed posts? I think the modals is a great idea. So breaking this PR up would let us decide what we like and easily add/revert each area as necessary.

Thoughts?

@MrPunyapal
Copy link
Collaborator Author

Looks like great work, Punyapal!

I’m still not entirely sold on adding the easy follow button to the posts on a feed, personally. Not adamantly against it, just not fully loving it haha.

Would it make sense to split this PR into 2? One for the easy follow on a person’s “followers” and “following” modals, and then a separate one for the feed posts? I think the modals is a great idea. So breaking this PR up would let us decide what we like and easily add/revert each area as necessary.

Thoughts?

it's not more than 15 lines but agreed so removing it.

@MrPunyapal MrPunyapal force-pushed the feat/easy-follow branch 2 times, most recently from abf768f to ed642ff Compare August 26, 2024 15:23
nunomaduro
nunomaduro requested changes Sep 3, 2024
View reviewed changes
app/Livewire/Concerns/Followable.php Outdated Show resolved Hide resolved
resources/views/livewire/links/index.blade.php Outdated Show resolved Hide resolved
@MrPunyapal MrPunyapal force-pushed the feat/easy-follow branch 7 times, most recently from cef2570 to a53441c Compare September 7, 2024 11:37
@nunomaduro nunomaduro merged commit 7bac2d8 into main Sep 21, 2024
@nunomaduro nunomaduro deleted the feat/easy-follow branch September 21, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunomaduro nunomaduro Awaiting requested review from nunomaduro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve following users
3 participants
@MrPunyapal @steven-fox @nunomaduro