Feat/show hide link #437
Merged
Feat/show hide link #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamKem
requested changes
Jul 23, 2024
app/Livewire/Links/Index.php
Outdated
| @@ -155,7 +173,14 @@ public function refresh(): void | |||
| public function render(): View | |||
| { | |||
| $user = User::query() | |||
| ->with(['links']) | |||
| ->with([ | |||
| 'links' => function (HasMany $query): HasMany { | |||
There was a problem hiding this comment.
You can utilise the when() method here to run the conditional inline & apply the callback.
For example:
->with([
'links' => fn (HasMany $query): HasMany => $query
->when(
auth()->id() !== $this->userId,
fn (Builder $query): Builder => $query
->where('show', true)
),
])
There was a problem hiding this comment.
You can utilise the when() method here to run the conditional inline & apply the callback.
For example:
->with([ 'links' => fn (HasMany $query): HasMany => $query ->when( auth()->id() !== $this->userId, fn (Builder $query): Builder => $query ->where('show', true) ), ])
this looks better
MrPunyapal
requested changes
Jul 23, 2024
database/migrations/2024_07_23_055716_add_show_to_links_table.php
Outdated
Show resolved
Hide resolved
Akhmami
commented
Jul 23, 2024
There was a problem hiding this comment.
I removed overflow-hidden because truncate was already available in the
tag, and move h-12 to parent div.
Akhmami
commented
Jul 23, 2024
There was a problem hiding this comment.
This will persistent the link description element centered
MrPunyapal
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added show/hide link based guest, authentication user and current user