[WIP] feat: 2FA #256
Merged
[WIP] feat: 2FA #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
franbarbalopez
commented
Apr 25, 2024
•
franbarbalopez
commented
- Livewire component for 2FA
- Now app use Fortify Login with 2FA confirmation if 2FA is enabled on that user
- Added livewire component on profile view
- password confirmation
- OTP verification
Closed
nunomaduro
requested changes
May 4, 2024
|
@nunomaduro this is ready to merge |
MrPunyapal
force-pushed
the
feat/two-factor-authentication
branch
from
63d8a0e
to
300bdad
Compare
MrPunyapal
force-pushed
the
feat/two-factor-authentication
branch
from
490ab14
to
4b4988a
Compare
MrPunyapal
force-pushed
the
feat/two-factor-authentication
branch
from
4b4988a
to
c1eb758
Compare
The TwoFactorAuthenticationForm component has been refactored to improve code organization and readability. The changes include: - Adding the `User` model to the component's namespace - Adding the `Locked` attribute to the `showingQrCode`, `showingRecoveryCodes`, `code`, and `enabled` properties - Updating the `mount` method to set the `enabled` property based on the user's two-factor secret - Adding conditional checks in the `showRecoveryCodes` and `regenerateRecoveryCodes` methods to prevent execution when two-factor authentication is not enabled - Updating the `disableTwoFactorAuthentication` method to set the `enabled` property to false These changes aim to improve the maintainability and extensibility of the TwoFactorAuthenticationForm component.
The TwoFactorAuthenticationForm component has been refactored to improve code organization and readability. Changes include adding the `User` model to the component's namespace, introducing the `Locked` attribute to relevant properties, updating the `mount` method to set the `enabled` property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The `disableTwoFactorAuthentication` method has also been updated to set the `enabled` property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
Refactor the TwoFactorAuthenticationForm component to improve code organization and readability. Changes include adding the User model to the component's namespace, introducing the Locked attribute to relevant properties, updating the mount method to set the enabled property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The disableTwoFactorAuthentication method has also been updated to set the enabled property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
…nfiguration Update the `fortify.php` configuration file to enable the confirmation of two-factor authentication during the authentication process. This change sets the `confirm` option to `true` and the `confirmPassword` option to `true` in the `twoFactorAuthentication` feature configuration. This ensures that users are required to confirm their two-factor authentication setup by entering their password. This improvement enhances the security of the application by adding an extra layer of verification for two-factor authentication.
Refactor the TwoFactorAuthenticationForm component to improve code organization and readability. Changes include adding the User model to the component's namespace, introducing the Locked attribute to relevant properties, updating the mount method to set the enabled property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The disableTwoFactorAuthentication method has also been updated to set the enabled property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
Refactor the TwoFactorAuthenticationForm component to improve code organization and readability. Changes include adding the User model to the component's namespace, introducing the Locked attribute to relevant properties, updating the mount method to set the enabled property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The disableTwoFactorAuthentication method has also been updated to set the enabled property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
…cationFormTest.php The file `TwoFactorAuthenticationTest.php` has been renamed to `TwoFactorAuthenticationFormTest.php` to better reflect its purpose as a test for the `TwoFactorAuthenticationForm` component. This change improves code organization and maintainability.
…TwoFactorAuthenticationForm
MrPunyapal
force-pushed
the
feat/two-factor-authentication
branch
from
de194ec
to
f73f76e
Compare
…etter auto completions
…oFactorAuthenticationForm The ConfirmsPasswords trait has been added to the TwoFactorAuthenticationForm component to handle password confirmation. This trait provides methods to ensure that the user's password has been recently confirmed. This change improves the security and usability of the TwoFactorAuthenticationForm component by requiring password confirmation before performing sensitive actions.
…oFactorAuthenticationForm
…TwoFactorAuthenticationForm
…torAuthenticationForm
…TwoFactorAuthenticationForm
Refactor the TwoFactorAuthenticationForm component to improve code organization and readability. Changes include adding the User model to the component's namespace, introducing the Locked attribute to relevant properties, updating the mount method to set the enabled property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The disableTwoFactorAuthentication method has also been updated to set the enabled property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
Refactor the TwoFactorAuthenticationForm component to improve code organization and readability. Changes include adding the User model to the component's namespace, introducing the Locked attribute to relevant properties, updating the mount method to set the enabled property based on the user's two-factor secret, and adding conditional checks in methods to prevent execution when two-factor authentication is not enabled. The disableTwoFactorAuthentication method has also been updated to set the enabled property to false. These changes aim to enhance the maintainability and extensibility of the TwoFactorAuthenticationForm component.
Add the two_factor_secret, two_factor_recovery_codes, and two_factor_confirmed_at properties to the User model. This allows for the storage and retrieval of two-factor authentication information for users. The changes include updating the casts() method in the User model to include the new properties. This enhancement improves the functionality and security of the User model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.