Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: edit links #200

Merged
merged 28 commits into from
Jul 17, 2024
Merged

Feat: edit links #200

merged 28 commits into from
Jul 17, 2024

Conversation

digitlimit
Copy link
Contributor

@digitlimit digitlimit commented Apr 14, 2024 •
edited by MrPunyapal
Loading

What does this PR do

This PR adds the ability to edit links.

Screenshots

20240717-1453-22.7068336.mp4

closes #168

@digitlimit digitlimit self-assigned this Apr 14, 2024
@digitlimit digitlimit linked an issue Apr 14, 2024 that may be closed by this pull request
Feature: Edit Links #168
Closed
MrPunyapal
MrPunyapal requested changes Apr 14, 2024
View reviewed changes
app/Livewire/Links/Edit.php Outdated Show resolved Hide resolved
app/Livewire/Links/Index.php Outdated Show resolved Hide resolved
app/Livewire/Links/Edit.php Show resolved Hide resolved
resources/views/livewire/links/edit.blade.php Show resolved Hide resolved
resources/views/livewire/links/index.blade.php Outdated Show resolved Hide resolved
resources/views/livewire/links/index.blade.php Outdated Show resolved Hide resolved
@nunomaduro
Copy link
Member

Can you fix conflicts?

@nunomaduro nunomaduro changed the title Feat: edit links [WIP] Feat: edit links Apr 25, 2024
@pinkary-project pinkary-project deleted a comment from nunomaduro Apr 26, 2024
@digitlimit
Copy link
Contributor Author

Can you fix conflicts?

Okay, boss. Fixing.

MrPunyapal
MrPunyapal requested changes Apr 28, 2024
View reviewed changes
app/Livewire/Links/Index.php Outdated Show resolved Hide resolved
resources/views/livewire/links/index.blade.php Outdated Show resolved Hide resolved
@MrPunyapal
Copy link
Collaborator

one final change: can you refresh links/index after updating the link for the count also updated in real-time?

@nunomaduro you can takeover after that.

@MrPunyapal MrPunyapal requested a review from nunomaduro May 1, 2024 15:47
@digitlimit
Copy link
Contributor Author

@MrPunyapal I have made the changes

@MrPunyapal
Copy link
Collaborator

@digitlimit now you can remove WIP

@nunomaduro
Copy link
Member

Can we put the edit under a modal? Can you also add a few tests? Please once is done, remove the WIP.

@digitlimit
Copy link
Contributor Author

Can we put the edit under a modal? Can you also add a few tests? Please once is done, remove the WIP.
@nunomaduro Boss, I have added some tests.

Is there a modal I could reuse?

@MrPunyapal
Copy link
Collaborator

Is there a modal I could reuse?

Can you check the following and followers component?

@digitlimit digitlimit changed the title [WIP] Feat: edit links Feat: edit links May 11, 2024
@digitlimit
Copy link
Contributor Author

@nunomaduro

Can we put the edit under a modal? Can you also add a few tests? Please once is done, remove the WIP.

Done!

MrPunyapal
MrPunyapal requested changes Jun 9, 2024
View reviewed changes
resources/views/livewire/flash-messages/show.blade.php Outdated Show resolved Hide resolved
tests/Unit/Livewire/Links/EditTest.php Show resolved Hide resolved
tests/Unit/Livewire/Links/EditTest.php Outdated Show resolved Hide resolved
digitlimit and others added 21 commits July 17, 2024 20:15
@digitlimit @MrPunyapal
Add livewire attributes to Edit component
d6a9fdb
@digitlimit @MrPunyapal
Add livewire attributes to Index component
b815b35
@digitlimit @MrPunyapal
Add show warning for click counter reset for URL update
52f89fc
@digitlimit @MrPunyapal
Add edit form cancel event
af0555a
@digitlimit @MrPunyapal
remove DownloadUserAvatar event on link updated
e25497c
@digitlimit @MrPunyapal
remove link model property
34456a3
@digitlimit @MrPunyapal
inject model instance in edit link method
4f25f6f
@digitlimit @MrPunyapal
add event to links edit form cancel button
f8a885c
@digitlimit @MrPunyapal
add link edit dispatch in index
fd3cd06
@digitlimit @MrPunyapal
handle link edit dispatch
3d7b785
@digitlimit @MrPunyapal
fix conflict in index
2d42c28
@digitlimit @MrPunyapal
add doc block to edit method
78414e8
@digitlimit @MrPunyapal
add refresh links/index
d2aa929
@digitlimit @MrPunyapal
add link edit tests
607e389
@digitlimit @MrPunyapal
fix modal link edit form notification z-index
4fff42a
@MrPunyapal
feat: Add dispatch to open and close modal in link edit component
24c720f
@MrPunyapal
Refactor link edit button in links index view
b893182
@MrPunyapal
Refactor: removed unwanted code from index
e513696
@MrPunyapal
Refactor link edit button in links index view
d596f03
@MrPunyapal
removed edit icon SVG component
1f9c10c
@MrPunyapal
chore: Update flash message wrapper z-index in show.blade.php
f9a9a9a
@MrPunyapal MrPunyapal requested review from CamKem and removed request for nunomaduro July 17, 2024 15:35
@nunomaduro nunomaduro merged commit 7fb9d8b into main Jul 17, 2024
@nunomaduro nunomaduro deleted the feat/edit-links branch July 17, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPunyapal MrPunyapal MrPunyapal approved these changes

@CamKem CamKem Awaiting requested review from CamKem

Assignees

@digitlimit digitlimit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Edit Links
3 participants
@digitlimit @nunomaduro @MrPunyapal