Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: char count after questioning #143

Merged
merged 2 commits into from
Apr 6, 2024
Merged

Conversation

MrPunyapal
Copy link
Collaborator

fixing this issue #141
also, improved the way of counting characters

@nunomaduro nunomaduro requested review from ryangjchandler and removed request for nunomaduro April 6, 2024 10:52
Copy link
Contributor

@ryangjchandler ryangjchandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need the watcher at all to do this, you can just use $wire.content.length instead since Livewire 3 runs completely on Alpine.

@MrPunyapal
Copy link
Collaborator Author

You shouldn't need the watcher at all to do this, you can just use $wire.content.length instead since Livewire 3 runs completely on Alpine.

done

@MrPunyapal MrPunyapal force-pushed the fix/char-count-after-questioning branch from 48c4ac0 to 0c09720 Compare April 6, 2024 11:40
@nunomaduro nunomaduro merged commit 679f6cf into main Apr 6, 2024
@nunomaduro nunomaduro deleted the fix/char-count-after-questioning branch April 6, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants