Merge pull request #535 from pinkary-project/feat/adding-bleeding-edge

Feat: adding bleeding edge in PHPStan
pinkary-project · Aug 31, 2024 · e7136d7 · e7136d7
2 parents 28bd258 + 39c67c5
commit e7136d7
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 8 deletions.
diff --git a/app/Console/Commands/PerformDatabaseBackupCommand.php b/app/Console/Commands/PerformDatabaseBackupCommand.php
@@ -32,7 +32,7 @@ public function handle(): void
 
         File::copy(database_path('database.sqlite'), database_path('backups/'.$filename));
 
-        $glob = type(File::glob(database_path('backups/*.sql')))->asArray();
+        $glob = File::glob(database_path('backups/*.sql'));
 
         collect($glob)->sort()->reverse()->slice(20)->each(
             fn (string $backup): bool => File::delete($backup),

diff --git a/app/Http/Controllers/QuestionController.php b/app/Http/Controllers/QuestionController.php
@@ -7,7 +7,6 @@
 use App\Jobs\IncrementViews;
 use App\Models\Question;
 use App\Models\User;
-use Illuminate\Http\Response;
 use Illuminate\Support\Facades\Gate;
 use Illuminate\View\View;
 
@@ -16,7 +15,7 @@
     /**
      * Display the question.
      */
-    public function show(User $user, Question $question): Response|View
+    public function show(User $user, Question $question): View
     {
         Gate::authorize('view', $question);
 

diff --git a/app/Livewire/Concerns/ConfirmsPasswords.php b/app/Livewire/Concerns/ConfirmsPasswords.php
@@ -25,8 +25,10 @@ protected function ensurePasswordIsConfirmed(string $idToConfirm, ?int $maximumS
      */
     protected function passwordIsConfirmed(?int $maximumSecondsSinceConfirmation = null): bool
     {
-        $maximumSecondsSinceConfirmation = $maximumSecondsSinceConfirmation !== null && $maximumSecondsSinceConfirmation !== 0 ? $maximumSecondsSinceConfirmation : config('auth.password_timeout', 900);
+        $maximumSecondsSinceConfirmation = $maximumSecondsSinceConfirmation !== null && $maximumSecondsSinceConfirmation !== 0 ? $maximumSecondsSinceConfirmation : config()->integer('auth.password_timeout', 900);
 
-        return (time() - session('auth.password_confirmed_at', 0)) < $maximumSecondsSinceConfirmation;
+        $confidedAt = is_int(session('auth.password_confirmed_at')) ? session('auth.password_confirmed_at') : 0;
+
+        return (time() - $confidedAt) < $maximumSecondsSinceConfirmation;
     }
 }
diff --git a/app/Models/Question.php b/app/Models/Question.php
@@ -156,7 +156,7 @@ public function mentions(): Collection
         }
 
         preg_match_all("/@([^\s,.?!\/@<]+)/i", type($this->content)->asString(), $contentMatches);
-        preg_match_all("/@([^\s,.?!\/@<]+)/i", type($this->answer)->asString(), $answerMatches);
+        preg_match_all("/@([^\s,.?!\/@<]+)/i", $this->answer, $answerMatches);
 
         $mentions = array_unique(array_merge($contentMatches[1], $answerMatches[1]));
 

diff --git a/app/Models/User.php b/app/Models/User.php
@@ -67,7 +67,7 @@ final class User extends Authenticatable implements FilamentUser, MustVerifyEmai
     /**
      * The attributes that should be hidden for serialization.
      *
-     * @var array<int, string>
+     * @var list<string>
      */
     protected $hidden = [
         'password',

diff --git a/app/Services/GitHub.php b/app/Services/GitHub.php
@@ -77,6 +77,7 @@ private function getSponsorships(string $username): array
             ));
         }
 
+        /** @var array<int, array{monthlyPriceInDollars: int}>|bool|null */
         $body = $response->json('data.user.sponsorshipForViewerAsSponsorable');
 
         return is_array($body) ? $body : [];

diff --git a/app/Services/ParsableContent.php b/app/Services/ParsableContent.php
@@ -40,7 +40,7 @@ public function parse(string $content): string
     {
         return (string) collect($this->providers)
             ->reduce(function (string $parsed, string $provider): string {
-                $provider = type(new $provider())->as(ParsableContentProvider::class);
+                $provider = new $provider();
 
                 return $provider->parse($parsed);
             }, $content);

diff --git a/phpstan.neon b/phpstan.neon
@@ -1,5 +1,6 @@
 includes:
     - vendor/larastan/larastan/extension.neon
+    - vendor/phpstan/phpstan/conf/bleedingEdge.neon
 
 parameters:
     checkMissingIterableValueType: true