Refactor notifications to use named parameters

pinkary-project · Apr 7, 2024 · 7324bd3 · 7324bd3
1 parent f8a5c10
commit 7324bd3
Show file tree

Hide file tree

Showing 12 changed files with 20 additions and 20 deletions.
diff --git a/app/Livewire/LinkSettings/Edit.php b/app/Livewire/LinkSettings/Edit.php
@@ -57,7 +57,7 @@ public function update(Request $request): void
         $user->update(['settings' => $validated]);
 
         $this->dispatch('link-settings.updated');
-        $this->dispatch('notification.created', 'Link settings updated.');
+        $this->dispatch('notification.created', message: 'Link settings updated.');
     }
 
     /**

diff --git a/app/Livewire/Links/Create.php b/app/Livewire/Links/Create.php
@@ -59,7 +59,7 @@ public function store(Request $request): void
         $this->url = '';
 
         $this->dispatch('link.created');
-        $this->dispatch('notification.created', 'Link created.');
+        $this->dispatch('notification.created', message: 'Link created.');
     }
 
     /**

diff --git a/app/Livewire/Links/Index.php b/app/Livewire/Links/Index.php
@@ -79,7 +79,7 @@ public function destroy(int $linkId): void
 
         $link->delete();
 
-        $this->dispatch('notification.created', 'Link deleted.');
+        $this->dispatch('notification.created', message: 'Link deleted.');
     }
 
     /**

diff --git a/app/Livewire/Questions/Create.php b/app/Livewire/Questions/Create.php
@@ -92,7 +92,7 @@ public function store(Request $request): void
         $this->anonymously = $user->prefers_anonymous_questions;
 
         $this->dispatch('question.created');
-        $this->dispatch('notification.created', 'Question sent.');
+        $this->dispatch('notification.created', message: 'Question sent.');
     }
 
     /**

diff --git a/app/Livewire/Questions/Edit.php b/app/Livewire/Questions/Edit.php
@@ -44,7 +44,7 @@ public function update(): void
 
         $this->answer = '';
 
-        $this->dispatch('notification.created', 'Question answered.');
+        $this->dispatch('notification.created', message: 'Question answered.');
         $this->dispatch('question.updated');
     }
 
@@ -61,7 +61,7 @@ public function report(): void
             'is_reported' => true,
         ]);
 
-        $this->dispatch('notification.created', 'Question reported.');
+        $this->dispatch('notification.created', message: 'Question reported.');
         $this->dispatch('question.reported');
     }
 
@@ -70,7 +70,7 @@ public function report(): void
      */
     public function ignore(): void
     {
-        $this->dispatch('notification.created', 'Question ignored.');
+        $this->dispatch('notification.created', message: 'Question ignored.');
 
         $this->dispatch('question.ignore', questionId: $this->questionId);
     }

diff --git a/app/Livewire/Questions/Show.php b/app/Livewire/Questions/Show.php
@@ -75,7 +75,7 @@ public function ignore(): void
         }
 
         if ($this->inIndex) {
-            $this->dispatch('notification.created', 'Question ignored.');
+            $this->dispatch('notification.created', message: 'Question ignored.');
 
             $this->dispatch('question.ignore', questionId: $this->questionId);
 

diff --git a/tests/Unit/Livewire/FlashMessages/ShowTest.php b/tests/Unit/Livewire/FlashMessages/ShowTest.php
@@ -9,12 +9,12 @@
 
     $component = Livewire::test(Show::class);
 
-    $component->dispatch('notification.created', 'Hello, world!');
+    $component->dispatch('notification.created', message: 'Hello, world!');
 
     $component->assertSee('Hello, world!');
     $component->assertDontSee('Goodbye, world!');
 
-    $component->dispatch('notification.created', 'Goodbye, world!');
+    $component->dispatch('notification.created', message: 'Goodbye, world!');
 
     $component->assertDontSee('Hello, world!');
     $component->assertSee('Goodbye, world!');
@@ -23,7 +23,7 @@
 test('flushes flash message', function () {
     $component = Livewire::test(Show::class);
 
-    $component->dispatch('notification.created', 'Hello, world!');
+    $component->dispatch('notification.created', message: 'Hello, world!');
 
     $component->assertSee('Hello, world!');
     $component->assertSee('Hello, world!');

diff --git a/tests/Unit/Livewire/LinkSettings/EditTest.php b/tests/Unit/Livewire/LinkSettings/EditTest.php
@@ -41,7 +41,7 @@
     $component->call('update');
 
     $component->assertDispatched('link-settings.updated');
-    $component->assertDispatched('notification.created', 'Link settings updated.');
+    $component->assertDispatched('notification.created', message: 'Link settings updated.');
 
     $user->refresh();
 

diff --git a/tests/Unit/Livewire/Links/CreateTest.php b/tests/Unit/Livewire/Links/CreateTest.php
@@ -19,7 +19,7 @@
     $component->call('store');
 
     $component->assertDispatched('link.created');
-    $component->assertDispatched('notification.created', 'Link created.');
+    $component->assertDispatched('notification.created', message: 'Link created.');
 
     $user->refresh();
 
@@ -43,7 +43,7 @@
     $component->call('store');
 
     $component->assertDispatched('link.created');
-    $component->assertDispatched('notification.created', 'Link created.');
+    $component->assertDispatched('notification.created', message: 'Link created.');
 
     $user->refresh();
 

diff --git a/tests/Unit/Livewire/Questions/CreateTest.php b/tests/Unit/Livewire/Questions/CreateTest.php
@@ -56,7 +56,7 @@
     $component->assertSet('content', '');
     $component->assertSet('anonymously', true);
 
-    $component->assertDispatched('notification.created', 'Question sent.');
+    $component->assertDispatched('notification.created', message: 'Question sent.');
     $component->assertDispatched('question.created');
 
     $question = App\Models\Question::first();
@@ -187,7 +187,7 @@
     $component->assertSet('content', '');
     $component->assertSet('anonymously', false);
 
-    $component->assertDispatched('notification.created', 'Question sent.');
+    $component->assertDispatched('notification.created', message: 'Question sent.');
     $component->assertDispatched('question.created');
 
     $question = App\Models\Question::first();
@@ -217,7 +217,7 @@
     $component->assertSet('content', '');
     $component->assertSet('anonymously', true);
 
-    $component->assertDispatched('notification.created', 'Question sent.');
+    $component->assertDispatched('notification.created', message: 'Question sent.');
     $component->assertDispatched('question.created');
 
     $question = App\Models\Question::first();
@@ -248,7 +248,7 @@
     $component->assertSet('content', '');
     $component->assertSet('anonymously', false);
 
-    $component->assertDispatched('notification.created', 'Question sent.');
+    $component->assertDispatched('notification.created', message: 'Question sent.');
     $component->assertDispatched('question.created');
 
     $question = App\Models\Question::first();

diff --git a/tests/Unit/Livewire/Questions/EditTest.php b/tests/Unit/Livewire/Questions/EditTest.php
@@ -83,7 +83,7 @@
 
     $component->call('ignore');
 
-    $component->assertDispatched('notification.created', 'Question ignored.');
+    $component->assertDispatched('notification.created', message: 'Question ignored.');
     $component->assertDispatched('question.ignore', questionId: $this->question->id);
 });
 

diff --git a/tests/Unit/Livewire/Questions/ShowTest.php b/tests/Unit/Livewire/Questions/ShowTest.php
@@ -100,7 +100,7 @@
     ]);
 
     $component->call('ignore');
-    $component->assertDispatched('notification.created', 'Question ignored.');
+    $component->assertDispatched('notification.created', message: 'Question ignored.');
     $component->assertDispatched('question.ignore');
 });