Skip to content

Commit

Permalink
ipv6: Fix exthdrs offload registration.
Browse files Browse the repository at this point in the history
Without this fix, ipv6_exthdrs_offload_init doesn't register IPPROTO_DSTOPTS
offload, but returns 0 (as the IPPROTO_ROUTING registration actually succeeds).

This then causes the ipv6_gso_segment to drop IPv6 packets with IPPROTO_DSTOPTS
header.

The issue detected and the fix verified by running MS HCK Offload LSO test on
top of QEMU Windows guests, as this test sends IPv6 packets with
IPPROTO_DSTOPTS.

Signed-off-by: Anton Nayshtut <anton@swortex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Anton Nayshtut authored and davem330 committed Mar 6, 2014
1 parent d746ca9 commit d2d273f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions net/ipv6/exthdrs_offload.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ int __init ipv6_exthdrs_offload_init(void)
int ret;

ret = inet6_add_offload(&rthdr_offload, IPPROTO_ROUTING);
if (!ret)
if (ret)
goto out;

ret = inet6_add_offload(&dstopt_offload, IPPROTO_DSTOPTS);
if (!ret)
if (ret)
goto out_rt;

out:
Expand Down

0 comments on commit d2d273f

Please sign in to comment.