Skip to content

Commit

Permalink
[GFS2] Remove pointless argument relating to truncate
Browse files Browse the repository at this point in the history
For some reason a function pointer was being passed through
the truncate code which only ever took one value. This removes
the function pointer and replaces it with a single call to
the function in question.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Steven Whitehouse committed Jan 24, 2006
1 parent 8ca05c6 commit aa6a85a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 12 deletions.
15 changes: 6 additions & 9 deletions fs/gfs2/bmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -841,8 +841,7 @@ static int truncator_journaled(struct gfs2_inode *ip, uint64_t size)
return 0;
}

static int trunc_start(struct gfs2_inode *ip, uint64_t size,
gfs2_truncator_t truncator)
static int trunc_start(struct gfs2_inode *ip, uint64_t size)
{
struct gfs2_sbd *sdp = ip->i_sbd;
struct buffer_head *dibh;
Expand Down Expand Up @@ -873,7 +872,7 @@ static int trunc_start(struct gfs2_inode *ip, uint64_t size,
if (do_div(junk, sdp->sd_jbsize))
error = truncator_journaled(ip, size);
} else if (size & (uint64_t)(sdp->sd_sb.sb_bsize - 1))
error = truncator(ip, size);
error = gfs2_truncator_page(ip, size);

if (!error) {
ip->i_di.di_size = size;
Expand Down Expand Up @@ -980,12 +979,11 @@ static int trunc_end(struct gfs2_inode *ip)
* Returns: errno
*/

static int do_shrink(struct gfs2_inode *ip, uint64_t size,
gfs2_truncator_t truncator)
static int do_shrink(struct gfs2_inode *ip, uint64_t size)
{
int error;

error = trunc_start(ip, size, truncator);
error = trunc_start(ip, size);
if (error < 0)
return error;
if (error > 0)
Expand All @@ -1009,8 +1007,7 @@ static int do_shrink(struct gfs2_inode *ip, uint64_t size,
* Returns: errno
*/

int gfs2_truncatei(struct gfs2_inode *ip, uint64_t size,
gfs2_truncator_t truncator)
int gfs2_truncatei(struct gfs2_inode *ip, uint64_t size)
{
int error;

Expand All @@ -1020,7 +1017,7 @@ int gfs2_truncatei(struct gfs2_inode *ip, uint64_t size,
if (size > ip->i_di.di_size)
error = do_grow(ip, size);
else
error = do_shrink(ip, size, truncator);
error = do_shrink(ip, size);

return error;
}
Expand Down
3 changes: 1 addition & 2 deletions fs/gfs2/bmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ int gfs2_block_map(struct gfs2_inode *ip,
uint64_t *dblock, uint32_t *extlen);

typedef int (*gfs2_truncator_t) (struct gfs2_inode * ip, uint64_t size);
int gfs2_truncatei(struct gfs2_inode *ip, uint64_t size,
gfs2_truncator_t truncator);
int gfs2_truncatei(struct gfs2_inode *ip, uint64_t size);
int gfs2_truncatei_resume(struct gfs2_inode *ip);
int gfs2_file_dealloc(struct gfs2_inode *ip);

Expand Down
2 changes: 1 addition & 1 deletion fs/gfs2/ops_inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -994,7 +994,7 @@ static int setattr_size(struct inode *inode, struct iattr *attr)
return error;
}

error = gfs2_truncatei(ip, attr->ia_size, gfs2_truncator_page);
error = gfs2_truncatei(ip, attr->ia_size);
if (error)
return error;

Expand Down

0 comments on commit aa6a85a

Please sign in to comment.