Skip to content

Commit

Permalink
hfs: remove extra mdb write on unmount
Browse files Browse the repository at this point in the history
HFS calls 'hfs_write_super()' from 'hfs_put_super()' in order to write the MDB
to the media. However, it is not needed because VFS calls '->sync_fs()' before
calling '->put_super()' - so by the time we are in 'hfs_write_super()', the MDB
is already synchronized.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
dedekind authored and Al Viro committed Jul 22, 2012
1 parent b593523 commit a3742d4
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions fs/hfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,6 @@ static int hfs_sync_fs(struct super_block *sb, int wait)
*/
static void hfs_put_super(struct super_block *sb)
{
if (sb->s_dirt)
hfs_write_super(sb);
hfs_mdb_close(sb);
/* release the MDB's resources */
hfs_mdb_put(sb);
Expand Down

0 comments on commit a3742d4

Please sign in to comment.