Skip to content

Commit

Permalink
cpufreq: amd-pstate: Optimize amd_pstate_update_limits()
Browse files Browse the repository at this point in the history
Don't take and release the mutex when prefcore isn't present and
avoid initialization of variables that will be initially set
in the function.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Reviewed-by: Perry Yuan <perry.yuan@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
  • Loading branch information
superm1 committed Sep 11, 2024
1 parent ad4caad commit 45722e7
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/cpufreq/amd-pstate.c
Original file line number Diff line number Diff line change
Expand Up @@ -810,17 +810,17 @@ static void amd_pstate_update_limits(unsigned int cpu)

cpudata = policy->driver_data;

mutex_lock(&amd_pstate_driver_lock);
if ((!amd_pstate_prefcore) || (!cpudata->hw_prefcore))
goto free_cpufreq_put;
if (!amd_pstate_prefcore)
return;

mutex_lock(&amd_pstate_driver_lock);
ret = amd_get_highest_perf(cpu, &cur_high);
if (ret)
goto free_cpufreq_put;

prev_high = READ_ONCE(cpudata->prefcore_ranking);
if (prev_high != cur_high) {
highest_perf_changed = true;
highest_perf_changed = (prev_high != cur_high);
if (highest_perf_changed) {
WRITE_ONCE(cpudata->prefcore_ranking, cur_high);

if (cur_high < CPPC_MAX_PERF)
Expand Down

0 comments on commit 45722e7

Please sign in to comment.