Skip to content

Conversation

@jonathanfuller-pingidentity
Copy link
Contributor

@jonathanfuller-pingidentity jonathanfuller-pingidentity commented Oct 22, 2025

Change Description

CDI-475

Fixes error when importing pingone_branding_theme where use_default_background and either background_color or background_image have values. Because the default branding theme has use_default_background configured along with background_color, opted to remove validation from use_default_background altogether. Since this is less restrictive, it should not break any existing Terraform-managed configurations.

Change Characteristics

  • This PR contains beta functionality
  • This PR requires introduction of breaking changes
  • No changelog entry is needed

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

  • Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
    • The changelog entry has been included according to the changelog process
    • Changes have proper test coverage (including regression tests)
    • Impacted resource, data source and schema descriptions have been reviewed and updated
    • Impacted resource and data source documentation HCL examples have been reviewed and updated
    • Does not introduce breaking changes (unless required to do so)
    • I am aware that changes to generated code may not be merged

Required SDK Upgrades

N/A

Testing

This PR has been tested with:

  • Unit tests (please paste commands and results below)
  • Acceptance tests (please paste commands and results below)
  • End-to-end tests (please paste the link to the actions workflow runs)
  • Not applicable (no evidences needed)

Shell Command(s)

TF_ACC=1 go test -count=1 -run='TestAccBrandingTheme' -v

Testing Results

Expand Results
=== RUN   TestAccBrandingThemeDefault_RemovalDrift
=== PAUSE TestAccBrandingThemeDefault_RemovalDrift
=== RUN   TestAccBrandingThemeDefault_Full
=== PAUSE TestAccBrandingThemeDefault_Full
=== RUN   TestAccBrandingThemeDefault_BadParameters
=== PAUSE TestAccBrandingThemeDefault_BadParameters
=== RUN   TestAccBrandingTheme_RemovalDrift
=== PAUSE TestAccBrandingTheme_RemovalDrift
=== RUN   TestAccBrandingTheme_NewEnv
=== PAUSE TestAccBrandingTheme_NewEnv
=== RUN   TestAccBrandingTheme_Full
=== PAUSE TestAccBrandingTheme_Full
=== RUN   TestAccBrandingTheme_Minimal
=== PAUSE TestAccBrandingTheme_Minimal
=== RUN   TestAccBrandingTheme_Change
=== PAUSE TestAccBrandingTheme_Change
=== RUN   TestAccBrandingTheme_ValidationChecks
=== PAUSE TestAccBrandingTheme_ValidationChecks
=== RUN   TestAccBrandingTheme_BadParameters
=== PAUSE TestAccBrandingTheme_BadParameters
=== CONT  TestAccBrandingThemeDefault_RemovalDrift
=== CONT  TestAccBrandingTheme_ValidationChecks
=== CONT  TestAccBrandingTheme_Full
=== CONT  TestAccBrandingTheme_NewEnv
=== CONT  TestAccBrandingThemeDefault_BadParameters
=== CONT  TestAccBrandingTheme_RemovalDrift
=== CONT  TestAccBrandingTheme_BadParameters
=== CONT  TestAccBrandingThemeDefault_Full
=== CONT  TestAccBrandingTheme_Minimal
=== CONT  TestAccBrandingTheme_Change
--- PASS: TestAccBrandingTheme_ValidationChecks (0.19s)
--- PASS: TestAccBrandingTheme_Minimal (3.39s)
--- PASS: TestAccBrandingTheme_Full (4.85s)
--- PASS: TestAccBrandingTheme_BadParameters (4.92s)
--- PASS: TestAccBrandingTheme_Change (9.01s)
--- PASS: TestAccBrandingTheme_NewEnv (39.26s)
--- PASS: TestAccBrandingThemeDefault_BadParameters (39.64s)
--- PASS: TestAccBrandingThemeDefault_Full (39.82s)
--- PASS: TestAccBrandingThemeDefault_RemovalDrift (65.23s)
--- PASS: TestAccBrandingTheme_RemovalDrift (68.92s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        69.621s

End-to-end Tests Workflow Links

N/A

@jonathanfuller-pingidentity jonathanfuller-pingidentity requested a review from a team as a code owner October 22, 2025 14:37
Copy link
Collaborator

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
But it likely does need a bug changelog entry with the same number as this PR since the issue implies that the user couldn't achieve valid configuration before and now they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants