Skip to content

perf(checker): size declaration storage by unique entries #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Unclip1843 wants to merge 1 commit into from
Closed

perf(checker): size declaration storage by unique entries #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions crates/ts_goport/src/checker/checker_p24.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,14 +492,13 @@ impl Checker {
if prop_set.is_empty() {
prop_set.push(single_prop);
}
let declaration_count = prop_set
.iter()
.map(|&prop| self.sym(prop).declarations.len())
.sum();
// PERF: the declarations are collected on the stack. A list of 0 or 1
// declarations is stored with no heap list (no malloc). A longer list
// moves into one `Vec` for `Declarations::from`, as before.
let mut declarations: SmallVec<[Node; 4]> = SmallVec::with_capacity(declaration_count);
// Size by unique declarations, not their repeated occurrences across
// constituents. The resulting symbol retains this buffer, so reserving
// the occurrence count can retain a Cartesian product's worth of slack.
let mut declarations: SmallVec<[Node; 4]> = SmallVec::new();
// PERF: Go `core.AppendIfUnique` scans the list for each declaration,
// which is quadratic in a long list (blueprint: 43k calls with 181
// declarations, 178 of them distinct; the scans were about half of
Expand All @@ -525,7 +524,7 @@ impl Checker {
}
for &declaration in self.sym(prop).declarations.iter() {
// Go: core.AppendIfUnique
declaration_set.add(&mut declarations, declaration, declaration_count);
declaration_set.add(&mut declarations, declaration, 0);
}
let t = self.get_type_of_symbol(prop);
if first_type.is_nil() {
Expand Down